FOUR-32304: Prevent duplicate DevLinks from breaking bundle lists#8920
Merged
Conversation
CarliPinell
reviewed
Jul 22, 2026
CarliPinell
left a comment
Contributor
There was a problem hiding this comment.
Reviewed FOUR-32304. One validation issue worth fixing before merge; otherwise the DevLink create-only + remote version availability approach looks solid.
CarliPinell
requested changes
Jul 22, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue & Reproduction Steps
DevLink allows multiple Linked Instance records with different names to point to the same destination URL. Connecting the newer duplicate replaces the OAuth client used by the previous connection, leaving installed bundles associated with stale credentials. Their remote version checks can then return errors that surface as local HTTP 500 responses and prevent the Local Bundles list from loading.
To reproduce, link a remote instance and install bundles from it, add the same destination URL again under a different name, and complete the new connection. Open Admin > DevLink > Local Bundles and observe the failed version checks for bundles associated with the stale connection. The QA recordings are attached to FOUR-32304. Manual local fixtures named
FOUR-32304 REPRO - Legacy Bundle 1andFOUR-32304 REPRO - Legacy Bundle 2, linked to the stale DevLink with remote IDs 1 and 2, were also used to validate the legacy-data behavior.Solution
422validation message.200response withavailable: falseandversion: nullwhen remote version checks fail, while marking successful responses as available.Connection unavailable, and disable Update, Reinstall, and Add a Copy until their associated connection is available.How to Test
vendor/bin/phpunit tests/Feature/Admin/DevLinkTest.php tests/Model/DevLinkTest.php tests/Feature/Api/DevLinkTest.php --no-coverage.npm run development.Connection unavailable, and remote actions are disabled.Update Available, missing remote bundles remain unavailable, and remote actions are enabled only for available bundles.Related Tickets & Packages