Skip to content

VITE LOGIN INBOX: Migrating Login and Inbox to Vite#8916

Open
henryjonathanquispe wants to merge 4 commits into
developfrom
VITE_INBOX
Open

VITE LOGIN INBOX: Migrating Login and Inbox to Vite#8916
henryjonathanquispe wants to merge 4 commits into
developfrom
VITE_INBOX

Conversation

@henryjonathanquispe

@henryjonathanquispe henryjonathanquispe commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Related Tickets & Packages

VITE_VIEW='{"app.login_view":"vite.auth.login","tasks.index":"vite.tasks.index"}'

#Instructions to install

> npm run i
> npm run dev
> npm run vite:build

To update the routes:
php artisan config:clear

#MInimal changes
PACKAGE-DATA-SOURCES
https://github.com/ProcessMaker/package-data-sources/pull/492

PACKAGE-VARIABLE-FINDER
https://github.com/ProcessMaker/package-variable-finder/pull/70

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@henryjonathanquispe
henryjonathanquispe changed the base branch from VITE_JONAS to develop July 23, 2026 19:44
@henryjonathanquispe henryjonathanquispe changed the title VITE INBOX: POC to test the ease of migrating other views to vite VITE LOGIN INBOX: Migrating Login and Inbox to Vite Jul 23, 2026
@gitguardian

gitguardian Bot commented Jul 23, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
34069781 Triggered Generic Password bc1d2d6 resources/views/vite/auth/login.blade.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nolanpro

Copy link
Copy Markdown
Contributor

@henryjonathanquispe a few suggestions

  • See if we can avoid adding .vue to all import statements by adding it to the extensions in the config:
     // vite.config.js
     resolve: {
       extensions: ['.mjs', '.js', '.ts', '.jsx', '.tsx', '.json', '.vue'],
       // ...existing aliases
     }
    
  • Once we transition a route, we should full-on commit to it and delete the old one. So I would get rid of the VITE_VIEW and config/app.php setting, and instead, hard-code the new blade template in the controller and remove .js("resources/js/tasks/index.js", "public/js/tasks/index.js") form webpack.mix.js.
  • Going along with the above, as part of this PR, convert all login templates to use vite. For example, change.blade.php, newLogin.blade.php (is this 'newLogin' template even necessary any more?), and any template that uses auth-language-scripts and auth-language-scripts-minimal partials. That way we can get this PR super clean and self contained!
  • Update package.json: "production": "mix --production && mix --mix-config=webpack-login.mix.js --production && vite build"

@henryjonathanquispe
henryjonathanquispe force-pushed the VITE_INBOX branch 2 times, most recently from 585ac49 to 58441fd Compare July 24, 2026 19:45
VITE_INBOX: update AGENTS.md

VITE_INBOX: remove webpack-login, change to vite

VITE_INBOX: update task controller, remove unnecesary files changed

VITE_INBOX: remove unnecesary files changed by extension, reduce the PR

VITE_INBOX: remove tasks js files from webpack
@processmaker-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants