FOUR-30920: Remove expected DevLink ping 401#8897
Conversation
|
QA server K8S was successfully deployed https://ci-09ba128f9d.engk8s.processmaker.net |
CarliPinell
left a comment
There was a problem hiding this comment.
Approved.
No observations found
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34069781 | Triggered | Generic Password | a633694 | resources/views/auth/passwords/reset.blade.php | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Please disregard the GitGuardian warning, as it is a false positive inherited from develop through the latest merge. The same finding was previously reported in PR #8871 under GitGuardian incident 34069781. |
|
Hi @eiresendez Just in case please check that alert for GitGuardian in this pull |
|
QA server K8S was successfully deployed https://ci-09ba128f9d.engk8s.processmaker.net |
thanks @CarliPinell I created this ticket https://processmaker.atlassian.net/browse/FOUR-32376 it's a false-positive. |





Issue & Reproduction Steps
Creating a new DevLink currently stores the local DevLink record and then calls
GET /api/1.0/devlink/{id}/pingbefore OAuth has completed. Because the DevLink does not have a usable access token yet, the ping returns a browser-visible 401 even though the flow is expected to continue to the remote OAuth/login step.To reproduce:
Solution
ok,authorization_required, orerror.okandauthorization_required, and show the existing error state only for real failures.How to Test
vendor/bin/phpunit tests/Feature/Api/DevLinkTest.php --filter Pingvendor/bin/phpunit tests/Feature/Api/DevLinkTest.phpnpm run developmentManual check:
Related Tickets & Packages
ci:deploy