Skip to content

fix(notification-bell): improve error handling for notification requests#1778

Closed
joshnajojo12 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
joshnajojo12:fix/notification-bell-error-handling-v2
Closed

fix(notification-bell): improve error handling for notification requests#1778
joshnajojo12 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
joshnajojo12:fix/notification-bell-error-handling-v2

Conversation

@joshnajojo12
Copy link
Copy Markdown
Contributor

Closes #1659

Summary

This PR improves error handling in the NotificationBell component by preventing notification-related API failures from being silently ignored.

Changes Made

  • Added dedicated error handling for notification fetch failures.
  • Added user-friendly feedback when notifications cannot be loaded.
  • Improved handling of mark-as-read request failures.
  • Removed silent failure paths that made debugging difficult.
  • Preserved existing notification functionality and user experience.

Testing

  • npm run lint ✅
  • npm run type-check ✅

Files Changed

  • src/components/NotificationBell.tsx

@vercel
Copy link
Copy Markdown

vercel Bot commented May 31, 2026

@joshnajojo12 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix labels May 31, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@joshnajojo12
Copy link
Copy Markdown
Contributor Author

Closing this PR because the changes are already present in the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] NotificationBell silently ignores notification API failures

1 participant