Skip to content

Chore: Resolve Deprecated Packages (Recharts v3, ESLint v9, Next-PWA)#1541

Closed
ArshVermaGit wants to merge 18 commits into
Priyanshu-byte-coder:mainfrom
ArshVermaGit:main_3
Closed

Chore: Resolve Deprecated Packages (Recharts v3, ESLint v9, Next-PWA)#1541
ArshVermaGit wants to merge 18 commits into
Priyanshu-byte-coder:mainfrom
ArshVermaGit:main_3

Conversation

@ArshVermaGit
Copy link
Copy Markdown
Contributor

Description

This PR eliminates the massive wall of deprecation warnings (inflight, rollup-plugin-terser, recharts, eslint) that were clogging up the npm install logs and introducing future technical debt.

Resolved Issue

Resolves #1539

Fixes:

  • 📈 Recharts Migration: Upgraded from ^2.12.7 to ^3.8.1. This removes legacy React 17 dependencies (like defaultProps) and improves SSR compatibility.
  • ⚙️ Next PWA Fork: The original next-pwa package is dead. Replaced it with the community-maintained @ducanh2912/next-pwa drop-in replacement, which purges the deprecated rollup-plugin-terser sub-dependency.
  • 🧹 ESLint Flat Config: Upgraded ESLint to ^9.0.0 and migrated the legacy .eslintrc.json to the modern Flat Config (eslint.config.mjs). Also cleaned up several unused eslint-disable comments across the codebase.
  • 🚀 SSR Optimization: Removed { ssr: false } from our dynamic chart imports in DashboardPage, allowing Next.js 15 to properly render the skeleton loaders on the server.

Breaking Changes / Follow-ups Needed

The major version bumps to Next.js 15 and Recharts v3 introduced a few strict TypeScript errors that currently fail the npm run build step (e.g., req.ip was removed from NextRequest, and Recharts Tooltip generic types have changed). These will need to be patched before this can be deployed.

How to Verify

  1. Pull down this branch.
  2. Run npm install and verify the output is perfectly clean (0 deprecation warnings).
  3. Run npm run lint and verify there are no ESLint errors.
  4. Run npm run test to verify the unit test suite still passes.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

@ArshVermaGit is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts) labels May 29, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

Copy link
Copy Markdown
Contributor Author

@ArshVermaGit ArshVermaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Priyanshu-byte-coder ! Issue #1539 has been resolved. Please review the PR and merge it under GSSoC. Thanks!

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level3 GSSoC Level 3 - Advanced (45 points) labels May 30, 2026
Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR now has merge conflicts with main due to recent merges. Please rebase onto the latest main branch and resolve conflicts before we can merge.

@ArshVermaGit
Copy link
Copy Markdown
Contributor Author

This PR now has merge conflicts with main due to recent merges. Please rebase onto the latest main branch and resolve conflicts before we can merge.

Done Please review!

@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

This PR now has merge conflicts with main. Please rebase your branch against the latest main and force-push to resolve. Run: git fetch upstream && git rebase upstream/main

# Conflicts:
#	.eslintrc.json
#	package-lock.json
#	src/app/u/[username]/opengraph-image.tsx
@github-actions github-actions Bot added the type:devops GSSoC type bonus: devops (+15 pts) label May 31, 2026
@ArshVermaGit
Copy link
Copy Markdown
Contributor Author

@Priyanshu-byte-coder merge conflicts are resolved please review and merge

@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

This PR has merge conflicts with the current main branch. Please rebase your branch onto main, resolve the conflicts, and force-push. Once conflicts are resolved and the PR is marked as mergeable it will be reviewed for merging.

@github-actions github-actions Bot added the type:security GSSoC type bonus: security (+20 pts) label May 31, 2026
@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 31, 2026

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
33523564 Triggered Generic High Entropy Secret 29bddf6 .env.example View secret
33523565 Triggered Supabase Service Role JWT 29bddf6 .env.example View secret
33523566 Triggered JSON Web Token 29bddf6 .env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

Closing — this PR accidentally includes Python automation scripts (fix_goaltracker.py, fix_header.py, fix_script.py, fix_ts.py, etc.) that should not be committed to the repository. Please remove these files, and also update the PR description — the Recharts v3 migration is a large change that should be validated against the current main branch before merging.

@ArshVermaGit ArshVermaGit deleted the main_3 branch May 31, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level3 GSSoC Level 3 - Advanced (45 points) type:devops GSSoC type bonus: devops (+15 pts) type:security GSSoC type bonus: security (+20 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Technical Debt: Resolve Deprecated Packages to Prevent Future Instability

2 participants