feat(emoji): add suggestion review notifications

[PrivateGER]

What

Why

Additional info (optional)

Checklist

• Read the contribution guide
• Test working in a local environment
• (If needed) Add story of storybook
• (If needed) Update CHANGELOG.md
• (If possible) Add tests

Summary by CodeRabbit

• New Features

  • Added notifications when submitted custom emoji suggestions are accepted.
  • Added pending-review indicators to admin navigation and the admin dashboard.
  • Added notification settings and localized messaging for accepted suggestions.
  • Added API and streaming support for managing emoji suggestions.
  • Added links from acceptance notifications to emoji management.

• Bug Fixes

  • Improved queue refresh behavior to prevent outdated status information from overriding current results.

• Tests

  • Expanded coverage for suggestion notifications, queue updates, and navigation status refreshes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f4f19f72-ba3d-4003-9b82-b2c680fd8a66

📥 Commits

Reviewing files that changed from the base of the PR and between 2a21733 and c699150.

📒 Files selected for processing (30)

• locales/index.d.ts
• packages/backend/src/core/EmojiSuggestionService.ts
• packages/backend/src/core/GlobalEventService.ts
• packages/backend/src/core/entities/NotificationEntityService.ts
• packages/backend/src/models/Notification.ts
• packages/backend/src/models/json-schema/notification.ts
• packages/backend/src/models/json-schema/user.ts
• packages/backend/src/server/api/endpoints/admin/show-user.ts
• packages/backend/src/server/api/endpoints/i/update.ts
• packages/backend/src/types.ts
• packages/backend/test/unit/EmojiSuggestionService.ts
• packages/frontend-shared/js/const.ts
• packages/frontend/src/components/MkNotification.vue
• packages/frontend/src/navbar.ts
• packages/frontend/src/pages/admin/index.vue
• packages/frontend/src/pages/settings/notifications.vue
• packages/frontend/src/ui/_common_/navbar-for-mobile.vue
• packages/frontend/src/ui/_common_/navbar-h.vue
• packages/frontend/src/ui/_common_/navbar.vue
• packages/frontend/test/navbar.test.ts
• packages/misskey-js/src/autogen/apiClientJSDoc.ts
• packages/misskey-js/src/autogen/endpoint.ts
• packages/misskey-js/src/autogen/entities.ts
• packages/misskey-js/src/autogen/models.ts
• packages/misskey-js/src/autogen/types.ts
• packages/misskey-js/src/consts.ts
• packages/misskey-js/src/streaming.types.ts
• packages/sw/src/scripts/create-notification.ts
• packages/sw/src/sw.ts
• sharkey-locales/en-US.yml

---

Walkthrough

The change adds accepted emoji-suggestion notifications, moderator queue-change events, pending-review indicators, frontend notification handling, localization strings, tests, and generated Misskey API client types and methods.

Changes

Emoji suggestion workflow

Layer / File(s)	Summary
Notification and localization contracts locales/index.d.ts, packages/backend/src/models/..., packages/backend/src/core/entities/NotificationEntityService.ts, packages/backend/src/server/api/..., packages/backend/src/types.ts, packages/frontend-shared/js/const.ts, sharkey-locales/en-US.yml	The notification model and schemas define emojiSuggestionAccepted with emojiName. Notification settings and localization entries now support the new notification and pending-review text.
Queue events and acceptance handling packages/backend/src/core/EmojiSuggestionService.ts, packages/backend/src/core/GlobalEventService.ts, packages/misskey-js/src/streaming.types.ts, packages/backend/test/unit/EmojiSuggestionService.ts	Suggestion creation, acceptance, cancellation, and rejection publish queue-change events. Acceptance notifies the proposer. Tests cover moderator lookup failures, event publication, notification behavior, and recovery paths.
Pending-review state and navigation packages/frontend/src/navbar.ts, packages/frontend/src/pages/admin/index.vue, packages/frontend/src/ui/_common_/navbar*.vue, packages/frontend/test/navbar.test.ts	Moderators and admins track pending suggestions through API requests, stream events, focus refreshes, and stale-response protection. Admin navigation and the admin page display pending indicators.
Notification presentation and delivery packages/frontend/src/components/MkNotification.vue, packages/frontend/src/pages/settings/notifications.vue, packages/sw/src/scripts/create-notification.ts, packages/sw/src/sw.ts	The frontend and service worker render accepted emoji-suggestion notifications and open emoji management when the notification is selected.

Generated API client surface

Layer / File(s)	Summary
Endpoint request and response types packages/misskey-js/src/autogen/entities.ts, packages/misskey-js/src/autogen/models.ts	Generated aliases expose request and response types for emoji suggestions and several additional API operations.
Endpoint mappings packages/misskey-js/src/autogen/endpoint.ts	The Endpoints mapping includes admin antennas, emoji suggestions, drive alt-text generation, and top-posts operations.
API client request declarations packages/misskey-js/src/autogen/apiClientJSDoc.ts, packages/misskey-js/src/consts.ts	APIClient.request declarations document the added operations. Selected user endpoint documentation now includes read:account permission metadata.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Mergeability Score: ⚪ Minimal · up to c6991

This change adds emoji suggestion review notifications across the backend and client surfaces; no actionable merge-blocking risk remains, so it is merge-ready after normal checks.

Possibly related PRs

• PrivateGER/Sharkey#39: Introduced the emoji-suggestion functionality extended by this change.
• PrivateGER/Sharkey#40: Modified EmojiSuggestionService and related emoji-suggestion localization before this notification and queue-update work.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes the required headings but provides no implementation details, motivation, testing information, or completed checklist items.	Describe what changed, why it changed, and how it was tested; then complete the applicable checklist items.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding emoji suggestion review notifications.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/emoji-suggestions

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/frontend/src/components/MkNotification.vue

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

packages/frontend/src/navbar.ts

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

packages/frontend/src/pages/admin/index.vue

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

• 7 others

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c69915073e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".