Skip to content

fix(backend): restore scoped global antenna access - #41

Merged
PrivateGER merged 1 commit into
developfrom
fix/superantenna-api-token
Aug 12, 2026
Merged

fix(backend): restore scoped global antenna access#41
PrivateGER merged 1 commit into
developfrom
fix/superantenna-api-token

Conversation

@PrivateGER

@PrivateGER PrivateGER commented Aug 12, 2026

Copy link
Copy Markdown
Owner

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Summary by CodeRabbit

  • New Features

    • Added permission support for reading global antenna settings.
    • Authorized administrators can access global antenna data using appropriately scoped access tokens.
  • Bug Fixes

    • Corrected access handling so insufficient permissions or roles are rejected appropriately.
    • Global antenna responses now consistently include the global relay setting.

@PrivateGER
PrivateGER merged commit 2a21733 into develop Aug 12, 2026
1 of 3 checks passed
@PrivateGER
PrivateGER deleted the fix/superantenna-api-token branch August 12, 2026 22:35
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 873e961f-0105-4c28-a9c1-87d8b412769b

📥 Commits

Reviewing files that changed from the base of the PR and between 4126d1d and 0e94d13.

📒 Files selected for processing (3)
  • packages/backend/src/const.ts
  • packages/backend/src/server/api/endpoints/admin/antennas/global.ts
  • packages/backend/test/e2e/antennas.ts

Walkthrough

The change adds the read:admin:antennas permission, removes the endpoint’s secure metadata, and adds end-to-end tests for token scope and administrator role checks.

Changes

Admin antennas authorization

Layer / File(s) Summary
Permission and endpoint authorization contract
packages/backend/src/const.ts, packages/backend/src/server/api/endpoints/admin/antennas/global.ts
The public permissions list now includes read:admin:antennas. The global admin antennas endpoint no longer declares secure: true.
Authorization end-to-end validation
packages/backend/test/e2e/antennas.ts
Tests cover successful access with an admin-scoped token, PERMISSION_DENIED without the scope, and ROLE_PERMISSION_DENIED for non-admin tokens. The default antenna expectation includes useGlobalRelay: false.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/superantenna-api-token

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant