Repository navigation
build(deps): migrate location maps to MapLibre 6 - #48
Merged
Merged
Conversation
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pending MapLibre 6 update breaks the location map because it removes the default export and the old CSP bundles. Migrate the map imports and bundle its ESM worker locally so extension pages keep working; MapLibre 6 requires WebGL2.
This replaces #30. The production and development dependency groups are already merged in #44 and #46; redundant #32 is closed. Repository rules prevent direct updates to the protected Dependabot branch.
Validation
pnpm task lintpnpm task checkpnpm task test:unit(neutral, Chromium and Firefox targets)Both targets still build (
pnpm task build:chrome,pnpm task build:firefox)Worker source regeneration is not applicable:
packages/refract-coreis unchanged; the generated source check passed.pnpm task test:build-contracts:ci(36 tests)Prettier check on changed source/manifest/changelog and
git diff --checkChromium extension map loads controlled GeoJSON through its bundled same-origin MapLibre 6.4.1 worker.
Product Playwright location flow: reset, generate and manually add a location (3 tests).
Full PR CI, including Storybook, product E2E, API conformance and Chromium/Firefox runtime E2E.
CodeQL.
Changelog
CHANGELOG.mdin## [Unreleased]for user-facing changes.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Migrate location maps to MapLibre GL JS 6.4.1
maplibre-gldependency from 5.24.0 to the 6.4.1 range in package.jsonMapLibretype imports to namespace imports in map componentschrome-extensionandmoz-extensionoriginsMacroscope summarized 7db5d5d.
Summary by CodeRabbit