fix(i18n): follow the active language in settings labels - #42
TomaszJanusz wants to merge 1 commit into
Conversation
Settings copied some translated strings once at startup, so accent colors and several other labels stayed English after a language change. Long About links also spilled out of their buttons. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (19)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe options UI now resolves language, accent, spoofing, and X-Ray labels through functions. It adds localized intercepted-API count text and adjusts language and accent label presentation and About project-link wrapping. Tests cover language and accent labels. ChangesLocalized interface labels
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Language changes refresh the affected labels, and the current About link labels remain within their buttons. The change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Validation
pnpm task lintpnpm task checkpnpm task test:unitpnpm task build:chrome,pnpm task build:firefox)packages/refract-corechanged(
pnpm task generate:worker-source)Changelog
CHANGELOG.mdin## [Unreleased]for user-facing changes.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Make settings and X-Ray labels follow the active interface language
accentOptionLabel,getThemeAccentOptions), surface-method labels (getSurfaceMethodLabels), surface copy (getSurfaceCopy), and X-Ray category/status/source labels (categoryLabel,statusLabel,sourceShortLabel,sharedWorkerLabel).languageOptionLabelso the language selector shows English-only names in the English locale and bilingual names (English plus localized) in all other locales.interceptsApisformatter across en/es/pt/ru/uk so the spoofing method list reports the intercepted API count with singular/plural wording in each language.AboutSidebarwith a wrapping flex layout so long translated link labels wrap instead of overflowing.getThemeAccentOptions, surface-copy record, method-label record) must call the new function forms instead.Macroscope summarized 9dd96aa.
Summary by CodeRabbit