Skip to content

Making tabebm compatible with newer versions - #347

Open
mumair5393 wants to merge 4 commits into
PriorLabs:mainfrom
mumair5393:fix/tabebm-tabpfn-compat
Open

Making tabebm compatible with newer versions#347
mumair5393 wants to merge 4 commits into
PriorLabs:mainfrom
mumair5393:fix/tabebm-tabpfn-compat

Conversation

@mumair5393

@mumair5393 mumair5393 commented Jul 18, 2026

Copy link
Copy Markdown

Fix TabEBM compatibility with recent TabPFN API changes

get_preprocessed_dataset_chunks signature changed in recent TabPFN — splitter param renamed to split_fn and several required args added (max_data_size, equal_split_size, data_shuffle_seed, preprocessing_random_state). Also fixes the broken test.

Fixes #225

@mumair5393
mumair5393 requested a review from a team as a code owner July 18, 2026 13:19
@mumair5393
mumair5393 requested review from klemens-floege and removed request for a team July 18, 2026 13:19
@CLAassistant

CLAassistant commented Jul 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates imports and configurations to align with the new TabPFN API, including replacing ModelInterfaceConfig with InferenceConfig and using get_preprocessed_dataset_chunks. It also fixes an issue in train_test_split_allow_full_train where stratify was used without shuffling. The review feedback points out that max_data_size is hardcoded to 1000 in get_preprocessed_dataset_chunks and should instead use self.max_data_size to respect the user-configured maximum data size.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/tabpfn_extensions/tabebm/tabebm.py
Comment thread src/tabpfn_extensions/tabebm/tabebm.py Outdated
@mumair5393
mumair5393 force-pushed the fix/tabebm-tabpfn-compat branch from 675b8a2 to 1db8848 Compare July 18, 2026 13:24
@klemens-floege

Copy link
Copy Markdown
Contributor

@mumair5393 thank you for opening a PR into our repo. Plesae make sure all tests are passing then I will give it a review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9d7deba. Configure here.


from tabpfn.config import ModelInterfaceConfig, PreprocessorConfig
from tabpfn.utils import meta_dataset_collator
from tabpfn.architectures.interface import PerformanceOptions

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal architectures import path

Medium Severity

PerformanceOptions is imported from tabpfn.architectures.interface, an internal architectures path. Project guidance prefers stable public imports such as from tabpfn.classifier / tabpfn.regressor (or avoiding the symbol if a default already works), because architecture internals have moved across TabPFN releases.

Fix in Cursor Fix in Web

Triggered by learned rule: Import tabpfn classes from stable public API paths, not internal modules

Reviewed by Cursor Bugbot for commit 9d7deba. Configure here.

@klemens-floege klemens-floege left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mumair5393 thank you for opening a PR into our repo. Plesae make sure all tests are passing then I will give it a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TabEBM broken with recent TabPFN + test broken.

3 participants