Skip to content

Sync external-PR reviewer list with opensource-review-team - #1154

Open
noahho wants to merge 1 commit into
mainfrom
noah/sync-pr-reviewers-with-team
Open

Sync external-PR reviewer list with opensource-review-team#1154
noahho wants to merge 1 commit into
mainfrom
noah/sync-pr-reviewers-with-team

Conversation

@noahho

@noahho noahho commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Brings .github/pr-reviewers.txt back in line with the opensource-review-team roster.

Why

psinger-prior and bejaeger were being assigned reviews on external and Dependabot PRs in tabpfn-extensions (#368, #369, #370) despite not being members of opensource-review-team. This file is the actual source of reviewers — assign-pr-reviewer.yml fetches it over raw.githubusercontent — so it had silently drifted from the team it is meant to mirror.

Checked in both directions: every current team member was already in the file, so this is only the removal of the two extras. Order of the remaining eight is unchanged to keep the diff readable.

Removed (in file, not on team) psinger-prior, bejaeger
Added (on team, missing from file) none

If either of them should be reviewing OSS PRs, the fix is to add them to opensource-review-team and re-sync rather than to revert this.

Two things this does not fix

  • tabpfn-extensions/.github/CODEOWNERS is empty (0 bytes). assign-pr-reviewer.yml only fires when nothing else has requested a reviewer, and its comment assumes CODEOWNERS covers some paths — so in that repo every external and Dependabot PR falls through to the random picker.
  • The picker is random, not round robin. reviewers[Math.floor(Math.random() * reviewers.length)] is why one person drew two PRs in a row. Either request the team and let GitHub's own review assignment round-robin it (opensource-review-team already has push on the relevant repos, so no PAT is needed, contrary to the workflow comment), or make it deterministic with pr_number % reviewers.length.

Note for anyone editing this file later: the workflow parses it with .filter(Boolean), so it has no comment syntax — a # header line would be treated as a username.

🤖 Generated with Claude Code

The list had drifted: psinger-prior and bejaeger were being assigned reviews on
tabpfn-extensions despite not being members of opensource-review-team. Everyone
on the team was already present, so this is a removal of the two extras.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@noahho
noahho requested a review from a team as a code owner August 2, 2026 06:30
Copilot AI review requested due to automatic review settings August 2, 2026 06:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request syncs the repository’s external/Dependabot reviewer source list (.github/pr-reviewers.txt) with the opensource-review-team roster by removing two usernames that are not on the team, preventing them from being auto-assigned as reviewers.

Changes:

  • Removed bejaeger from .github/pr-reviewers.txt.
  • Removed psinger-prior from .github/pr-reviewers.txt.
  • Kept the remaining reviewer order unchanged to minimize diff noise.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@oscarkey oscarkey added the no changelog needed PR does not require a changelog entry label Aug 5, 2026
@oscarkey

oscarkey commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@noahho do we want to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog needed PR does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants