fix(hero-banner): center {} braces in the hexagon#16
Merged
Conversation
The hero banner's curly-braces glyph was sitting 14 units left of the hexagon center because the transform translated the brace group to (32, 62) rather than (46, 62). In the 80×80 brace frame the glyph is already centred at (40, 40); after scale(0.65) its centre lands at (26, 26); the translate must therefore put (26, 26) at the hexagon centre (72, 88), i.e. translate(46, 62), not translate(32, 62). The same glyph in logo_*.svg and og_card_*.svg was unaffected because those use a different hexagon position whose centre already sits at (40, 40) in the local frame, with no extra transform applied. Visible only on the hero banner, light + dark variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line transform fix. The `{}` glyph in `diagrams/hero_banner_{light,dark}.svg` was sitting 14 units left of the hex centre because the transform was `translate(32, 62)` when the math actually requires `translate(46, 62)`.
In the 80×80 brace frame the glyph is already centred at (40, 40). After `scale(0.65)` its centre lands at (26, 26). The translate must therefore put (26, 26) at the hex centre (72, 88), i.e. `translate(46, 62)`.
Logo and OG card were unaffected — those use the hexagon at its origin position where its centre already sits at (40, 40) in the local frame, with no extra transform applied.
Test plan