feat: per-combination virtual flag & downloadable file page objects - #1121
Open
PrestaEdit wants to merge 1 commit into
Open
feat: per-combination virtual flag & downloadable file page objects#1121PrestaEdit wants to merge 1 commit into
PrestaEdit wants to merge 1 commit into
Conversation
Adds page-object methods needed for PrestaShop core PR #41825 (per-combination
virtual products):
BO products / combinations edit modal
- setCombinationIsVirtual(page, boolean)
- setCombinationVirtualProductFile(page, filePath)
- getCombinationVirtualProductFileName(page)
FO product page (base classic, inherited by hummingbird and older themes)
- getProductDownloadFileName(page): returns the downloadable filename
shown for the currently selected combination/product, empty when none
Bump version to 0.0.13.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
PrestaEdit
added a commit
to PrestaEdit/PrestaShop
that referenced
this pull request
Sep 7, 2026
Points tests/UI to the PrestaEdit fork branch of ui-testing-library that exposes the new combination page-object methods and drops the temporary @ts-nocheck on the per-combination virtual e2e. Companion PR: PrestaShop/ui-testing-library#1121. Once merged and published, switch the dependency back to https://github.com/PrestaShop/ui-testing-library#main. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
PrestaEdit
added a commit
to PrestaEdit/PrestaShop
that referenced
this pull request
Sep 7, 2026
Points tests/UI to the PrestaEdit fork branch of ui-testing-library that exposes the new combination page-object methods and drops the temporary @ts-nocheck on the per-combination virtual e2e. Companion PR: PrestaShop/ui-testing-library#1121. Once merged and published, switch the dependency back to https://github.com/PrestaShop/ui-testing-library#main. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion library changes for PrestaShop/PrestaShop#41825 (per-combination virtual flag + downloadable file).
What
Why
PrestaShop/PrestaShop#41825 adds an `is_virtual` flag and a downloadable file to each combination. The e2e test that ships with that PR (`tests/UI/campaigns/functional/BO/03_catalog/01_products/23_virtualCombinations/01_perCombinationVirtual.ts`) needs these page-object methods. They don't exist yet — that's what fails `TypeScript Check` on the PR.
FO selector caveat
`getProductDownloadFileName` targets `div.product-download-file, .product__additional-info .product-download__filename` and returns `''` when neither node is found. The selectors match the current classic / hummingbird themes; if the theme templates land under different classes, the selector should be tightened together with the theme PR.
🤖 Generated with Claude Code