Skip to content

Match the demo orders' totalPaid to the fixtures - #1120

Draft
boo-code wants to merge 1 commit into
PrestaShop:mainfrom
boo-code:fix/demo-order-total-paid-34751
Draft

Match the demo orders' totalPaid to the fixtures#1120
boo-code wants to merge 1 commit into
PrestaShop:mainfrom
boo-code:fix/demo-order-total-paid-34751

Conversation

@boo-code

@boo-code boo-code commented Sep 5, 2026

Copy link
Copy Markdown
Contributor
Questions Answers
Branch? main
Description? src/data/demo/orders.ts encodes the demo orders' totalPaid, and four of the five values contradict the fixtures they describe: the fixture row states total_paid_tax_incl while totalPaid carries a figure short by total_shipping_tax_incl - 2.00. tests/UI/campaigns/functional/BO/02_orders/01_orders/02_filterOrders.ts:121 filters the orders grid by dataOrders.order_4.totalPaid, so the library has to agree with the fixtures for that filter to match a row.
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? eslint --ignore-path .gitignore src/data/demo/orders.ts and npx tsc --noEmit both exit 0. With the companion core branch installed, the orders grid filtered by dataOrders.order_4.totalPaid returns the order instead of an empty result.
Fixed issue or discussion? Fixes PrestaShop/PrestaShop#34751
Related PRs Companion to the core branch fix/demo-order-total-paid-34751, which corrects the same values in install-dev/fixtures/fashion/data/orders.xml. They have to land together.
Sponsor company

Values corrected

XKBKNABJK   61.80 -> 68.20
OHSATSERP   69.90 -> 169.90
UOYEVOLI    14.90 -> 21.30
FFATNOMMJ   14.90 -> 21.30
KHWLILZLL   20.90 -> 27.30

Each new figure is the total_paid_tax_incl the fixture already stated. OHSATSERP is a separate
pre-existing error rather than part of the same class: the fixture has always said 169.90 and only the
library said 69.90.

The five demo orders' totalPaid values were copied from a fixture row whose
total_paid contradicted its own total_paid_tax_incl. The core fixtures are being
corrected so each order's total_paid equals products + shipping - discounts; this
follows them.

order_2 was separately wrong: the fixture has always said 169.90 and the data
here said 69.90.

Companion to the core change for PrestaShop/PrestaShop#34751.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When you change the address on the order page, the amount of the Payment block also changes.

1 participant