Match the demo orders' totalPaid to the fixtures - #1120
Draft
boo-code wants to merge 1 commit into
Draft
Conversation
The five demo orders' totalPaid values were copied from a fixture row whose total_paid contradicted its own total_paid_tax_incl. The core fixtures are being corrected so each order's total_paid equals products + shipping - discounts; this follows them. order_2 was separately wrong: the fixture has always said 169.90 and the data here said 69.90. Companion to the core change for PrestaShop/PrestaShop#34751.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/data/demo/orders.tsencodes the demo orders'totalPaid, and four of the five values contradict the fixtures they describe: the fixture row statestotal_paid_tax_inclwhiletotalPaidcarries a figure short bytotal_shipping_tax_incl - 2.00.tests/UI/campaigns/functional/BO/02_orders/01_orders/02_filterOrders.ts:121filters the orders grid bydataOrders.order_4.totalPaid, so the library has to agree with the fixtures for that filter to match a row.eslint --ignore-path .gitignore src/data/demo/orders.tsandnpx tsc --noEmitboth exit 0. With the companion core branch installed, the orders grid filtered bydataOrders.order_4.totalPaidreturns the order instead of an empty result.fix/demo-order-total-paid-34751, which corrects the same values ininstall-dev/fixtures/fashion/data/orders.xml. They have to land together.Values corrected
Each new figure is the
total_paid_tax_inclthe fixture already stated.OHSATSERPis a separatepre-existing error rather than part of the same class: the fixture has always said
169.90and only thelibrary said
69.90.