Skip to content

Fix newsletter subscription cleanup on customer update #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Touxten merged 1 commit into from
Aug 28, 2026
Merged

Fix newsletter subscription cleanup on customer update #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ps_emailsubscription.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,14 +1007,29 @@ public function hookActionCustomerAccountAdd($params)

public function hookActionObjectCustomerUpdateBefore($params)
{
// Reload the customer to get the newsletter state currently persisted in the database.
// $params['object'] already contains the new value that is about to be saved.
// Comparing both states allows us to detect an actual subscription transition (0 -> 1)
// and avoid removing an existing email subscription during unrelated customer updates.
$customer = new Customer($params['object']->id);
$this->_origin_newsletter = (int) $customer->newsletter;

Db::getInstance()->execute('DELETE FROM ' . _DB_PREFIX_ . 'emailsubscription WHERE id_shop=' . (int) $params['object']->id_shop . ' AND email=\'' . pSQL($params['object']->email) . "'");
// Only handle a real newsletter subscription transition (0 -> 1).
// Existing email subscriptions must be preserved for unrelated customer updates.
if ($this->_origin_newsletter || !$params['object']->newsletter) {
return;
}

Db::getInstance()->execute(
'DELETE FROM ' . _DB_PREFIX_ . 'emailsubscription
WHERE id_shop=' . (int) $params['object']->id_shop . '
AND email=\'' . pSQL($params['object']->email) . "'"
);
}

public function hookActionCustomerAccountUpdate($params)
{
// Send newsletter-related emails only when the customer has just subscribed (0 -> 1).
if ($this->_origin_newsletter || !$params['customer']->newsletter) {
return;
}
Expand Down
Loading