Fix: Problem with the newsletter subscription module

[Codencode]

Questions	Answers
Description?	see: PrestaShop/PrestaShop#38446
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#38446.
How to test?	see: PrestaShop/PrestaShop#38446

[Codencode]

@kpodemski
have you had a chance to review this PR?

Thanks

[boherm]

Hi @Codencode!
Your CI is totally red!
I made a fix (#115) to avoid this in this repository.

Can you need rebase your branch? 🙏

[Codencode]

Hi @boherm,
Yes, I had noticed that everything was red, but I didn’t understand why—I thought it might be a temporary issue.
I performed the rebase and hope I did it correctly.

Thanks a lot!

[paulnoelcholot]

Hello @Codencode,

I tested your PR and it's good for me! 🎉

Thanks!

PR-2025-04-28_15.44.46.mp4

[kpodemski]

Hello @Codencode

I checked the old issue, this one PrestaShop/PrestaShop#17097, and it seems that this part of the code:
https://github.com/Codencode/ps_emailsubscription/blob/9eab6e01c91ec573158f80f9e68623423f9324dd/ps_emailsubscription.php#L961

Prevents running this code:
https://github.com/Codencode/ps_emailsubscription/blob/9eab6e01c91ec573158f80f9e68623423f9324dd/ps_emailsubscription.php#L966

while it may be good to skip it for existing subscribers, it should work for newly registered accounts and the confirmation email should work

what do you think?

[Codencode]

Hello @Codencode

I checked the old issue, this one PrestaShop/PrestaShop#17097, and it seems that this part of the code: https://github.com/Codencode/ps_emailsubscription/blob/9eab6e01c91ec573158f80f9e68623423f9324dd/ps_emailsubscription.php#L961

Prevents running this code: https://github.com/Codencode/ps_emailsubscription/blob/9eab6e01c91ec573158f80f9e68623423f9324dd/ps_emailsubscription.php#L966

while it may be good to skip it for existing subscribers, it should work for newly registered accounts and the confirmation email should work

what do you think?

Hi @kpodemski,
You're right, actually, something should be modified.
I'll try to create a PR so we can work on fixing the issue.

[Codencode]

I created the PR; actually, the code needed to be changed because those instructions should only be executed if the email is valid. There were also some unnecessary code duplications.

PR: #121