Fix PHPStan error - #249
Merged
Merged
Conversation
Quetzacoalt91
commented
Sep 9, 2026
Quetzacoalt91
commented
Member
| Questions | Answers |
|---|---|
| Description? | Fix the PHPStan error reported on #248 |
| Type? | bug fix |
| BC breaks? | Nope |
| Deprecations? | Nope |
| Fixed ticket? | Fixes #248 |
| How to test? | CI is green |
| Sponsor company | @PrestaShopCorp |
Quetzacoalt91
force-pushed
the
phpstan-error
branch
3 times, most recently
from
September 9, 2026 09:55
be83a4e to
80fb896
Compare
Member
Quetzacoalt91
force-pushed
the
phpstan-error
branch
from
September 9, 2026 09:57
80fb896 to
918b668
Compare
Member
Author
|
On it, sir! |
Quetzacoalt91
force-pushed
the
phpstan-error
branch
from
September 9, 2026 09:58
918b668 to
8458c23
Compare
Hlavtox
approved these changes
Sep 9, 2026
ps-jarvis
added
the
Waiting for QA
github-project-automation
Bot
moved this from Ready for review
to Merged
in PR Dashboard
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
Member
|
@Quetzacoalt91 Thanks boss 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.