important fix: process uploads only if configuration allows it - #83
Open
Markus-Gurkcity wants to merge 1 commit into
Open
important fix: process uploads only if configuration allows it#83Markus-Gurkcity wants to merge 1 commit into
Markus-Gurkcity wants to merge 1 commit into
Conversation
|
Hello @Markus-Gurkcity! This is your first pull request on contactform repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
kpodemski
approved these changes
Nov 15, 2025
Hlavtox
approved these changes
Nov 15, 2025
matthieu-rolland
approved these changes
Nov 20, 2025
Contributor
There was a problem hiding this comment.
thank you @Markus-Gurkcity
@paulnoelcholot here is checking that the configuration allows file upload on the backend side, so that it's not possible to bypass this just by modifying the html in the browser
github-project-automation
Bot
moved this from Ready for review
to Closed
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
in contactform module the PS configuration PS_CUSTOMER_SERVICE_FILE_UPLOAD is assigned to the template. If this configuration is false the upload file input and the form multipart attribute will be removed from the html:
The issue:
If a attacker modifies the html form in the browser and adds the form file upload input, the file will be send to prestashop an will be uploaded.
Fix:
check the configuration at the process/send method and reject any file uploads: