Run the syntax-check checkout on a supported Node version - #102
Draft
boo-code wants to merge 1 commit into
Draft
Conversation
The php-linter job still pinned actions/checkout@v3.1.0 while the three PHPStan jobs in the same file use @v6. That pin targets Node 20, which GitHub deprecated, so every run of PHP tests annotated the job with a "forced to run on Node.js 24" warning. Align it with the rest of the file. See PrestaShop/PrestaShop#34538
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php-linterjob pinnedactions/checkout@v3.1.0while the three PHPStan jobs in the same file use@v6.v3.1.0targets Node 20, which GitHub deprecated on 2025-09-19, so every run of PHP tests annotates that job with a "forced to run on Node.js 24" warning. This aligns it with the rest of the file.Node.js 20 is deprecated. The following actions target Node.js 20 ...: actions/checkout@v3.1.0. After, that annotation is gone.Measured
Read off the annotations of the newest
php.ymlrun ondev(run 33370758646, sha10ef9aa), notinferred from the file:
Only the first line comes from this repository.
@v6, used by the other three jobs in the same file,appears in no warning — that is the in-repo control for the choice of version.
Scope
This removes one of the four warnings. The other three come from
PrestaShop/.githuband affect everymodule repository using the shared CI, so they cannot be fixed here — see the issue comment for the
file-and-line inventory.
v7is the current major, but the other three jobs in this file are onv6and were not flagged, sov6keeps the file internally consistent and still resolves the warning. Moving all four to
v7would be alarger change than the reported symptom needs.
Checks
The workflow parses:
Symfony\Component\Yaml\Yaml::parse()returns the five jobsphp-linter,php-cs-fixer,phpstan-74-81,phpstan-81-84,phpstan, with fourcheckoutsteps all at@v6.