Skip to content

Release version 5.0.0 - #100

Merged
Quetzacoalt91 merged 38 commits into
masterfrom
dev
Sep 10, 2026
Merged

Release version 5.0.0#100
Quetzacoalt91 merged 38 commits into
masterfrom
dev

Conversation

@Hlavtox

@Hlavtox Hlavtox commented Aug 18, 2026

Copy link
Copy Markdown
Member
Questions Answers
Description? Release version 5.0.0
Type? refacto
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

Hlavtox and others added 30 commits November 14, 2025 12:21
Adjust user agent length based on PrestaShop version.
Modify user agent handling in contact form
Switched to external ci actions
…ingle-contact

ContactForm: Hide subject dropdown when only one contact is available
CI : PHPStan with common action
PHP support from 7.2 to 8.5 (PS 8.2+)
CI : Dependabot (PHP / Node / Github Actions)
@Hlavtox Hlavtox added this to the 4.4.4 milestone Aug 18, 2026
@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Aug 18, 2026
mattgoud and others added 2 commits August 28, 2026 15:07
9.1.5 is the last release of the 9.1 line: the 9.1.x branch was deleted from
the core once it shipped, so nothing newer will come out of it.
CI: pin PrestaShop 9.1.5 instead of the superseded 9.1.4 tag

@jolelievre jolelievre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version should be a major (min version changed) 5.0.0 (version needs to be bumped)

@mattgoud

mattgoud commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Heads up on the version number before this one goes out.

dev raises ps_versions_compliancy from 1.7.2.0 to 8.2.0, while the last published release, v4.4.3, still declares 1.7.2.0. Shops running PrestaShop 1.7 or 8.0/8.1 can install v4.4.3 today and will no longer be able to install this one, so the release is a breaking change and the table's BC breaks? no does not hold.

The rule agreed for the native modules in the 9.2.0 release preparation is that a raised minimum PrestaShop version means a major bump, whatever else the release contains. ps_banner was the first one out under it, published as v3.0.0 on 08/09, its PR #92 stating Type? improvement and BC breaks? yes (drops support for PrestaShop < 8.2.0 and PHP < 7.1).

So this one would be 5.0.0 rather than 4.4.4, which means:

  • $this->version in contactform.php and <version> in config.xml -> 5.0.0
  • this PR retitled, Type? improvement and BC breaks? yes
  • milestone 4.4.4 (File upload option & no dupplicate message #5) renamed to 5.0.0, keeping its number
  • at publication time, the release-drafter draft will propose v4.4.4, since this repo's .github/release-drafter.yml sets tag-template: v$NEXT_PATCH_VERSION, so the tag has to be corrected by hand before publishing

The README is already consistent with 8.2.0, so only the version fields are out of step.

Context: PrestaShop/PrestaShop#41648.

@Quetzacoalt91 Quetzacoalt91 changed the title Release version 4.4.4 Release version 5.0.0 Sep 10, 2026
@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Sep 10, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Sep 10, 2026
@Quetzacoalt91

Copy link
Copy Markdown
Member

🟢 Approved.

Checked the display of the recipient field on the form, as displayed on the original issue. All good for me.
The rest mainly changes the CI so nothing more needs to be tested here.

@Quetzacoalt91 Quetzacoalt91 added QA ✔️ Status: Check done, Code approved and removed Waiting for QA Status: Action required, Waiting for test feedback labels Sep 10, 2026
@Quetzacoalt91
Quetzacoalt91 merged commit 99e36e8 into master Sep 10, 2026
28 checks passed
@github-project-automation github-project-automation Bot moved this from To be tested to Merged in PR Dashboard Sep 10, 2026
@ps-jarvis ps-jarvis moved this from Merged to To be tested in PR Dashboard Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA ✔️ Status: Check done, Code approved

Projects

Status: To be tested

Development

Successfully merging this pull request may close these issues.