Skip to content

Let the tab links be the tablist's own children #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
boo-code wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Let the tab links be the tablist's own children #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions templates/catalog/product.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,12 @@

{block name='product_tabs'}
<div class="tabs">
{* The items carry role="presentation" so the links below them are the tablist's own children
in the accessibility tree. A bare <li> keeps its listitem role, and a tablist may only own
tabs, so the whole list fails the aria-required-children check. *}
<ul class="nav nav-tabs" role="tablist">
{if $product.description}
<li class="nav-item">
<li class="nav-item" role="presentation">
<a
class="nav-link{if $product.description} active js-product-nav-active{/if}"
data-toggle="tab"
Expand All @@ -152,7 +155,7 @@
{if $product.description} aria-selected="true"{/if}>{l s='Description' d='Shop.Theme.Catalog'}</a>
</li>
{/if}
<li class="nav-item">
<li class="nav-item" role="presentation">
<a
class="nav-link{if !$product.description} active js-product-nav-active{/if}"
data-toggle="tab"
Expand All @@ -162,7 +165,7 @@
{if !$product.description} aria-selected="true"{/if}>{l s='Product Details' d='Shop.Theme.Catalog'}</a>
</li>
{if $product.attachments}
<li class="nav-item">
<li class="nav-item" role="presentation">
<a
class="nav-link"
data-toggle="tab"
Expand All @@ -172,7 +175,7 @@
</li>
{/if}
{foreach from=$product.extraContent item=extra key=extraKey}
<li class="nav-item">
<li class="nav-item" role="presentation">
<a
class="nav-link"
data-toggle="tab"
Expand Down
9 changes: 6 additions & 3 deletions templates/checkout/_partials/steps/personal-information.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@
</div>

{else}
{* The items carry role="presentation" so the links below them are the tablist's own children
in the accessibility tree. A bare <li> keeps its listitem role, and a tablist may only own
tabs, so the whole list fails the aria-required-children check. *}
<ul class="nav nav-inline my-2" role="tablist">
<li class="nav-item">
<li class="nav-item" role="presentation">
<a
class="nav-link {if !$show_login_form}active{/if}"
data-toggle="tab"
Expand All @@ -65,11 +68,11 @@
</a>
</li>

<li class="nav-item">
<li class="nav-item" role="presentation">
<span class="nav-separator"> | </span>
</li>

<li class="nav-item">
<li class="nav-item" role="presentation">
<a
class="nav-link {if $show_login_form}active{/if}"
data-link-action="show-login-form"
Expand Down
Loading