Skip to content

Respect the country tax label setting on the product page - #232

Draft
boo-code wants to merge 1 commit into
PrestaShop:developfrom
boo-code:fix/tax-label-setting-on-product-page-21484
Draft

Respect the country tax label setting on the product page#232
boo-code wants to merge 1 commit into
PrestaShop:developfrom
boo-code:fix/tax-label-setting-on-product-page-21484

Conversation

@boo-code

@boo-code boo-code commented Sep 5, 2026

Copy link
Copy Markdown
Contributor
Questions Answers
Description? The product page prints "No tax" whenever taxes are disabled without consulting the country's "Display tax label" setting, which the very next branch of the same template already honours. $configuration.display_taxes_label is $this->context->country->display_tax_label (FrontController::getDisplayTaxesLabel()), so a merchant who turns that checkbox off still gets a tax statement on every product page. Both branches are now gated on the setting.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#21484
Sponsor company
How to test? Set a country's "Display tax label" to No (International > Locations > Countries), then disable taxes (International > Taxes > Enable taxes: No) and open a product page. Before: "No tax" is displayed. After: nothing is displayed. With the label set to Yes the behaviour is unchanged in both tax states.

Before

{if !$configuration.taxes_enabled}
  {l s='No tax' d='Shop.Theme.Catalog'}
{elseif $configuration.display_taxes_label}
  {$product.labels.tax_long}
{/if}

After

{if $configuration.display_taxes_label}
  {if $configuration.taxes_enabled}
    {$product.labels.tax_long}
  {else}
    {l s='No tax' d='Shop.Theme.Catalog'}
  {/if}
{/if}

Why this shape

PrestaShop/PrestaShop#25882 fixed the same defect for the cart summary and the
order confirmation table by gating on display_taxes_label together with taxes_enabled, and was merged
in October 2021. The product page was not part of it, which is why the issue is still open with this exact
template quoted in the thread. Using the same gate keeps the three places consistent rather than inventing
a rule for this one.

Scope

Only the product page template changes. The cart summary and the order confirmation table already respect
the setting since PrestaShop/PrestaShop#25882, and so does DeliveryOptionsFinder.

Companion to the same change in hummingbird: the two themes carry the same template and the same defect.

The product page showed "No tax" whenever taxes were disabled, without
consulting the country's "Display tax label" setting that the branch just
below it already honoured. A merchant who turned that label off still saw a
tax statement on every product.

Gate both branches on the setting, the way #25882 did for the cart summary
and the order confirmation table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FO - "No tax" label is displayed in the FO despite of disabling the "Display tax label" in the Countries page

1 participant