Skip to content

Follow the mobile menu state instead of flipping the header class #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
boo-code wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Follow the mobile menu state instead of flipping the header class #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions _dev/js/components/top-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,12 @@ export default class TopMenu extends DropDown {
}

toggleMobileMenu() {
$('#header').toggleClass('is-open');
if ($('#mobile_top_menu_wrapper').is(':visible')) {
// Called both when the menu is toggled and on every breakpoint crossing,
// so the state has to be read rather than flipped.
const isMobileMenuOpen = $('#mobile_top_menu_wrapper').is(':visible');

$('#header').toggleClass('is-open', isMobileMenuOpen);
if (isMobileMenuOpen) {
$('#notifications, #wrapper, #footer').hide();
} else {
$('#notifications, #wrapper, #footer').show();
Expand Down
Loading