Skip to content

Move both thumbnail selection classes together when swiping #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
boo-code wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Move both thumbnail selection classes together when swiping #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions _dev/js/product.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,12 @@ $(document).ready(() => {
const swipe = (selectedThumb, thumbParent) => {
const newSelectedThumb = thumbParent.find(prestashop.themeSelectors.product.thumb);

// Swap active classes on thumbnail
selectedThumb.removeClass('selected');
newSelectedThumb.addClass('selected');
// Swap active classes on thumbnail. Both have to move together: "selected" carries the
// styling and "js-thumb-selected" is what themeSelectors.product.selected looks for, so
// dropping only one of them leaves the previous thumbnail matching that selector and the
// next swipe acts on a growing set of thumbnails.
selectedThumb.removeClass('selected js-thumb-selected');
newSelectedThumb.addClass('selected js-thumb-selected');

// Update sources of both cover and modal cover
modalProductCover.prop('src', newSelectedThumb.data('image-large-src'));
Expand Down
Loading