Stop showing the No tax label when taxes are disabled - #223
Draft
boo-code wants to merge 1 commit into
Draft
Conversation
The block showed "No tax" whenever taxes were off, ignoring the country's display tax label setting, while the cart summary requires both before showing any tax label. A shop that is not liable for VAT had the string on every product page and nowhere else. The product page now follows the same condition as the cart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No taxon every product while the cart prints nothing, so a shop that is not liable for VAT carries the string in one place only.The two are not written the same way.
cart-summary-totals.tplrequires both flags before showing any tax label,{if $configuration.display_taxes_label && $configuration.taxes_enabled}, whereas this block short-circuits on the first one and printsNo taxregardless of the country's display tax label setting.The condition now matches the cart. With taxes on, nothing changes: that branch was already gated on
display_taxes_label. With taxes off, the label is omitted, as it already is in the cart.No taxunder the price. After: nothing there, matching the cart summary.With tax enabled the page is unchanged, and with a country whose "Display tax label" is off the long label stays hidden as before.
No taxis the only wording removed and it has no other use in this theme, so nothing else needs translating.The same block exists in Hummingbird and behaves identically; a companion PR follows there if this direction is right.