Various fixes - #6
Merged
Merged
Conversation
- capture_exception() defaulted to catch_stack() - The "fake" DSN path called JSON.Parser.parse, which is gone in JSON v1, so the dry run mode threw instead of printing anything. - Attachment items were missing the filename header that sentry requires. - Transaction item headers declared a length one byte too long since the spec says that the newline terminating a payload is not part of it. - Transactions did not carry the release. - init() would allow being called twice, which would start a second - send_worker() task. - A declined trace sample stored an InhibitTransaction that was never cleared, which locked out tracing for the remaining life of the task. It now counts open spans like a real transaction and clears itself when the outermost one finishes. The exception is set_task_transaction, which deliberately stores one that never clears so that the parent's decision holds for the whole life of the child task.
clear_queue waited only until the channel was empty, which happens when send_worker takes the last payload rather than when its POST comes back, so events captured shortly before the process exited could be silently dropped. Refactored the code to close the channel and wait for send_worker() to finish.
Contributor
Author
|
(bump) |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a wee audit of the codebase with Claude and fixed a few things that came up, in particular:
Also updated the CI jobs and updated to HTTP.jl v2.