Fix flake in test_automation_listener_receives_notifications_and_processes_them - #23006
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Wait for the listener's LISTEN to be registered before making automation changes, since Postgres does not deliver notifications to connections that subscribe later. Co-Authored-By: bot_apk <apk@cognition.ai>
devin-ai-integration
Bot
requested review from
chrisguidry,
desertaxle and
zzstoatzz
as code owners
September 1, 2026 14:19
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a race in
test_automation_listener_receives_notifications_and_processes_them, which failed on main withassert 2 == 3(theautomation__createdcall was missing) in this run.The test started
listen_for_automation_changes()as a task and then slept 0.1 seconds before it created the automation. Postgres sends aNOTIFYonly to connections that already runLISTEN, so the notification is lost, not delayed, if the listener is not subscribed yet. On a loaded runner, the asyncpg connect plusreconcile_automations()can take more than 0.1 seconds, so thecreatednotification was lost and theretry_assertsloop could not recover it.The test now sends probe notifications with a random automation ID until the listener reports one. This proves the
LISTENis registered before the test makes real automation changes. The assertions filter the recorded calls by the automation ID, so a probe that arrives late cannot change the result.Verification
createdassertion, and the new test passed.tests/events/server/modelswith--numprocesses auto --maxprocesses 6 --dist worksteal: 39 passed.Checklist
<link to issue>"mint.json.Link to Devin session: https://app.devin.ai/sessions/c84ee4dd042541d7848c8a54c92cf8ea
Open in Devin Desktop: https://app.devin.ai/desktop/session/c84ee4dd042541d7848c8a54c92cf8ea?variant=devin