chore(test): WIP per-surface test projects and behavior baselines for the agent/store/tui split (P0) - #1269
Closed
gewenyu99 wants to merge 3 commits into
Closed
chore(test): WIP per-surface test projects and behavior baselines for the agent/store/tui split (P0)#1269gewenyu99 wants to merge 3 commits into
gewenyu99 wants to merge 3 commits into
Conversation
Type-only fixes for the 32 errors tsc reported. One runtime fix rides along: RevenueIntroScreen spread the POSTHOG_SDKS and STRIPE_SDKS sets before calling array methods on them, which previously threw on those branches. Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
Projects: store, agent, tui, cli, harness, architecture, keyed by today's
directories. New scripts test:<project> and test:arch, a surfaces workflow
that runs each project alone plus a production and CI bundle audit, aliases
and empty shape files for the future src/{store,agent,tui,cli} surfaces, and
a chunk manifest script for dist/.
Generated-By: PostHog Desktop
Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
Goldens recorded from the current tree: a frame per screen and overlay at two sizes through the real ScreenContainer, keyboard versus control action session diffs, store invariants, flow traces and screen analytics per program, post auth gate ids, the MCP control state sequence, and prod and CI chunk manifests. The import boundaries test seeds the 72 current violations and fails on new ones or stale entries. Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+10
to
+29
| name: Architecture | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1 | ||
| - uses: pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b # v2.4.1 | ||
| with: | ||
| version: 10.34.5 | ||
| run_install: false | ||
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version-file: 'package.json' | ||
| cache: 'pnpm' | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: node scripts/generate-version.cjs | ||
| - run: pnpm typecheck | ||
| - run: pnpm lint | ||
| - run: pnpm test:arch | ||
|
|
||
| surface: |
Comment on lines
+30
to
+56
| name: ${{ matrix.project }} | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| project: [store, agent, tui, cli, harness] | ||
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1 | ||
| - uses: pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b # v2.4.1 | ||
| with: | ||
| version: 10.34.5 | ||
| run_install: false | ||
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version-file: 'package.json' | ||
| cache: 'pnpm' | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: node scripts/generate-version.cjs | ||
| - run: pnpm test:${{ matrix.project }} --coverage | ||
| - uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # pin@v5.3.1 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| fail_ci_if_error: false | ||
| flags: ${{ matrix.project }} | ||
|
|
||
| bundle: |
Comment on lines
+57
to
+86
| name: Bundle audit | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1 | ||
| - uses: pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b # v2.4.1 | ||
| with: | ||
| version: 10.34.5 | ||
| run_install: false | ||
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version-file: 'package.json' | ||
| cache: 'pnpm' | ||
| - run: pnpm install --frozen-lockfile | ||
| - name: Production build and smoke test | ||
| run: pnpm build | ||
| - name: Production chunk manifest | ||
| run: | ||
| npx tsx scripts/chunk-manifest.no-jest.ts dist > | ||
| chunk-manifest.prod.json | ||
| - name: CI build and smoke test | ||
| run: pnpm build:ci | ||
| - name: CI chunk manifest | ||
| run: | ||
| npx tsx scripts/chunk-manifest.no-jest.ts dist > | ||
| chunk-manifest.ci.json | ||
| - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 | ||
| with: | ||
| name: chunk-manifests-${{ github.sha }} | ||
| path: chunk-manifest.*.json |
gewenyu99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 of the agent/store/tui split: Vitest projects per surface, a surfaces workflow, and goldens captured from the current tree that later phases must keep byte identical.
Baselines: 88 screen frames through the real ScreenContainer, keyboard versus control action session diffs, store invariants, flow traces and screen analytics per program, post auth gate ids, the MCP control state sequence, prod and CI chunk manifests, and an import boundaries test seeded with the 72 current cross surface edges. No behavior changes except the type fixes in the first commit, which also stops RevenueIntroScreen from calling array methods on a Set.
Created with PostHog Desktop