fix(orchestrator): carry the data-source next steps onto the outro - #1234
Open
Gilbert09 wants to merge 1 commit into
Open
fix(orchestrator): carry the data-source next steps onto the outro#1234Gilbert09 wants to merge 1 commit into
Gilbert09 wants to merge 1 commit into
Conversation
The integration program builds a pre-filled link per detected data source for the outro, but only the linear sequence asks a program for its outro data. The orchestrated sequence composes its own message from the drain result, so the links were built and then discarded on every orchestrated run — including the runs where the seeded warehouse step never connected anything, which is exactly when they are the only deterministic pointer the user has left. Adds `ProgramRun.buildOutroNextSteps`, a hook for a sequence that owns its own outro message: the sequence keeps the message, the program supplies the bullets. It is handed the runner-seeded task types that finished successfully, so the integration leaves the bullets off a run whose own warehouse step connected the sources — otherwise a successful run would end by asking the user to redo the work at a new-source form that collides with the source just created. The sequence stays ignorant of what any task type means. Branch: posthog/orchestrated-outro-next-steps Generated-By: PostHog Desktop Task-Id: 3db08a36-bd9a-4c3d-b384-d6070267db7c
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The integration program builds an outro bullet per detected data source — a
pre-filled link to that source's new-source form, plus the
wizard warehousecommand for doing them all at once. Those bullets only ever reach a user
through
buildOutroData, which is the linear sequence's seam.The orchestrated sequence doesn't use it. It composes its own outro message out
of the drain result (steps completed, steps skipped, any review conflict) and
calls
setOutroDatadirectly, with nonextSteps. So on an orchestrated run —the only flow that seeds the warehouse step at all — the links were built and
then dropped.
That lands hardest on the runs where they matter most. When the seeded
warehouse step is declined at its notice, times out unanswered, or skips, the
step never asks anything and never hands over a link of its own; those are the
majority of runs that reach it. The user was told during the run that the
wizard found connectable sources, and then finished the run with nothing
pointing at them. The report-checklist prompt fragment is best-effort by
design, and its own comment says the outro bullet "carries the same information
deterministically" — which wasn't true on this path.
Changes
ProgramRun.buildOutroNextSteps: the seam for a sequence thatowns its own outro message. The sequence keeps the message, the program
supplies the bullets.
the runner-seeded task types that reached
done.uses, and returns nothing when its own warehouse step completed — otherwise a
run that just connected the sources would end by asking the user to redo the
work at a form that collides with the source it created. Only
donecounts;every other terminal state left the work undone.
The sequence still knows nothing about what any task type means: it reports
statuses, the program interprets them.
Test plan
completedSeededTypesunit tests over a realQueueStore:doneis named;declined, agent-not-needed, failed and non-seeded tasks are not.
same links as the linear outro, still present when another seeded type
completed, absent once the warehouse step completed, absent with nothing
detected.
pnpm build, full unit suite (164 files / 2688 tests) andpnpm lintallgreen locally.
Created with PostHog Desktop