feat(gateway): code and report a refused mint - #1222
Open
brandonleung wants to merge 3 commits into
Open
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
brandonleung
force-pushed
the
brandon/wizard-w1-2-mint-refusal-code
branch
3 times, most recently
from
September 8, 2026 20:45
ebe3b05 to
0b01601
Compare
brandonleung
force-pushed
the
brandon/wizard-w1-2-mint-refusal-code
branch
from
September 8, 2026 20:57
0b01601 to
6aa520c
Compare
brandonleung
marked this pull request as ready for review
September 8, 2026 21:15
gewenyu99
approved these changes
Sep 8, 2026
gewenyu99
left a comment
gewenyu99
left a comment
Collaborator
There was a problem hiding this comment.
Okay hot take, prob doesn't matter. If we log mint refuse reason on the server with session attached, there is no reason to even send it to the client. They don't need to know if it's not actionable. For mint refuses, we gotta think about this.
Anything related to hitting limit and with an actionable please try again in time is fine. Anything else basically don't bother
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
typeof body.code === 'string' is true for the empty string, so a refusal carrying both keys lost its outcome whenever the code cleaned to nothing. The catalog doc gains the group this PR adds, and the precedence has fixtures that carry one key each, so swapping the arms goes red. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
brandonleung
force-pushed
the
brandon/wizard-w1-2-mint-refusal-code
branch
from
September 8, 2026 23:23
6aa520c to
eb9e605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A refused mint reaches the user as "Something went wrong", and nothing records that it happened, so the refusals this stack adds server-side are invisible from the client.
Changes
The refusal gets a code, a message, and an event.
gatewayerror group withGatewayMintRefusedandGatewayMintFailed; the refusal carries its status and outcome so the abort path resolves it instead of the generic unhandled code.gateway mint refusedis captured with status, outcome and program.codefirst, thenoutcome: the server's exception layer flattens a dict detail, so that is where the machine-readable value lands. Acodethat cleans to nothing does not shadow a usableoutcome.Test plan
pnpm test. Precedence is pinned by fixtures carrying one key each, plus the empty and control-only cases; the degraded bodies (non-JSON, empty, neither key, oversized, non-string) each have a case.