fix: don't show (detected) after manual framework pick - #1213
Open
ShobhanKarthish wants to merge 2 commits into
Open
fix: don't show (detected) after manual framework pick#1213ShobhanKarthish wants to merge 2 commits into
ShobhanKarthish wants to merge 2 commits into
Conversation
When auto-detection fails and the user picks a framework from the fallback picker, set manuallySelected so the intro Framework row omits the (detected) suffix — matching the Change framework path.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to the described UX bug and is covered by focused unit tests.
Pull request overview
Fixes a UX inconsistency in the PostHog integration intro screen where the Framework row could incorrectly display “(detected)” after the user manually chose a framework via the detection-failed fallback picker.
Changes:
- Set
manuallySelectedwhen the fallbackFrameworkPickercompletes, suppressing the misleading “(detected)” suffix. - Extract framework row suffix logic into
frameworkRowSuffixand add unit tests for it.
File summaries
| File | Description |
|---|---|
| src/ui/tui/screens/PostHogIntegrationIntroScreen.tsx | Marks fallback framework selection as manual and extracts suffix formatting into a helper. |
| src/ui/tui/screens/tests/PostHogIntegrationIntroScreen.test.ts | Adds unit tests covering the extracted suffix logic. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When auto-detection fails and the user picks a framework from the fallback picker, the intro still shows
Framework ✔ <name> (detected). That is the one path where detection definitely failed, so the suffix is misleading.The "Change framework" menu path already sets
manuallySelected(which suppresses the suffix). The detection-failedFrameworkPickerconfirm path never did.Changes
manuallySelectedso the Framework row omits(detected).frameworkRowSuffixfor the row suffix logic and cover it with unit tests.Test plan
vitest run src/ui/tui/screens/__tests__/PostHogIntegrationIntroScreen.test.ts(14 tests passed)Framework ✔ <name>without(detected)(detected); Change framework still omits itCloses #944