fix(audit): seed the capture-fires-on-success check - #1211
Open
sarahxsanders wants to merge 1 commit into
Open
Conversation
The comprehensive audit skill gains a fourth event-capture check that flags completion events firing on submit intent rather than on a confirmed server response. Its ledger is pre-seeded here, so the id has to exist in the seed or audit_resolve_checks rejects it as unknown and the check reports nothing. Pairs with the context-mill change that adds the check itself. Generated-By: PostHog Desktop Task-Id: 4fd61d6e-eb4e-498e-abfd-1d0b60d95a63
4 tasks
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to context-mill#388, which adds a new event-capture audit check.
capture-fires-on-successcheck would report nothing. This ledger is pre-seeded wizard-side, so an unseeded id gets rejected as unknown. Fixed: seeded it in the existingEvent Capturearea.Land this before #388 or the check sits dormant for a release.
Testing
pnpm build && pnpm test && pnpm fix— 2637 passing, lint clean. Verified against wizard-workbench apps with--local-context-mill.Checklist
pnpm build && pnpm test && pnpm fixCreated with PostHog Desktop