refactor: rename the single-destination replicator (was: duckling) - #86
Merged
Conversation
The component collided with two other 'duckling' terms: the duckgres Duckling K8s CR and PostHog's tenant data plane (posthog-duckling-* buckets). The component is now 'single-destination viaduck' everywhere: class SingleDestinationViaduck, SingleDestinationConfig, FatalSingleDestinationError, metrics prefix viaduck_single_destination_*, logger viaduck.single_destination, instance_id default, pipeline label prefix, and the temp view name. The ducklings k8s namespace strings stay (cluster-side fact; renaming that is an infra change). No behavior change; the feature is not deployed anywhere with dashboards, so the metric-series rename is free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The component's name collided twice over: duckgres has a
DucklingK8s CR (warehouse child resource), and PostHog's tenant data plane already owns 'duckling' (posthog-duckling-* buckets, tenant-duckling hostnames). The viaduck component is now single-destination viaduck everywhere.What changes
DucklingSingleDestinationViaduckDucklingConfigSingleDestinationConfigFatalDucklingErrorFatalSingleDestinationErrorviaduck_duckling_*metricsviaduck_single_destination_*viaduck.ducklingviaduck.single_destinationinstance_iddefault"duckling""single-destination"duckling-<dest>single-destination-<dest>_duckling_append_single_destination_appendDeliberately kept: the
ducklingsk8s namespace strings (allowed_secret_namespaces,allowed_endpoint_suffixes) — that's a cluster-side fact and renaming it is an infra change, not this one; and the PostHog tenant-plane names the tests mirror from prod.No behavior change; 1066 tests pass; ruff clean. The component is not deployed anywhere with dashboards, so the metric-series rename is free.