Publish source-ordered Trino image releases - #20
Merged
Conversation
bill-ph
approved these changes
Sep 7, 2026
bill-ph
left a comment
There was a problem hiding this comment.
Reviewed the current head and available CI status; no P0 blockers requiring code changes found. Remaining CI jobs are still in progress.\n\n— Robo Bill
fuziontech
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build the Trino image once, publish it to immutable ECR, and mirror the exact digest to GHCR. Source-ordered tags and index-level OCI source/revision annotations identify the built commit. ECR is the release source for new cells; GHCR retains the existing full-SHA and manual readable aliases. Existing charts state dispatch remains enabled for master pushes, but only after both registries pass digest read-back. Merging this PR therefore starts the existing build-and-dispatch path and can roll the existing dev Trino deployment, independently of the new empty cells.
Publication is limited to master pushes and manual runs on master, with master-scoped AWS OIDC credentials. Retries reuse a verified ECR release or its immutable source-annotated raw staging image. A failed GHCR mirror resumes from ECR without rebuilding. Existing immutable aliases must match exactly; readable aliases exist only in GHCR. Tag-push publication is removed; manual master runs retain readable aliases. Pull requests run contract tests without package-write or OIDC permissions.
Additional context and related issues
AWS_ECR_PUBLISH_IAM_ROLEis configured and its metadata confirms availability to this repository. Its operator-supplied value has not been independently verified or read back. The workflow masks the account ID and derives the ECR address from authenticated login; no real account ID is hard-coded in the current source or this description. No image publication or deployment was triggered during this setup.AGENTS.mdwith public-repository data-handling rules, synthetic-example requirements, runtime-secret guidance, and links to the existing development conventions.type=registry,oci-mediatypes=truebefore creating the annotated index. Default local Docker builds remain unchanged. Buildx applies index annotations only to OCI indexes; BuildKit documents the OCI media-type exporter flag. Digest aliases use Buildx's single-source copy behavior without annotations, preserving the original index bytes..github/TRINO_IMAGE_RELEASES.md.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: