Allow AI co-author trailers in commit messages - #16
Open
fuziontech wants to merge 1 commit into
Open
Conversation
Upstream's check-commit-messages action rejects any Co-authored-by or Assisted-by trailer that credits an AI model or coding tool. This fork writes some of its commits with those tools and wants them credited. Vendor the action's check.py at the pinned revision with one addition, an --allow-ai-attribution flag that drops the attribution rule, and run it from ci.yml instead of the action. Every other rule stays: subject style and length, description wrapping. Claude-Session: https://claude.ai/code/session_01WCY5Jf2BQPCVKJTZU1TpEe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream's
airlift/github-actions/check-commit-messagesrejects anyCo-authored-by/Assisted-bytrailer that credits an AI model or coding tool. This fork writes some of its commits with those tools and wants them credited, so:.github/scripts/check-commit-messages.py: the action'scheck.pyvendored at the pinned revision (1652e24) with one addition, an--allow-ai-attributionflag that drops the attribution rule. Subject style/length and description wrapping rules are unchanged..github/workflows/ci.yml: thecheck-commit-messagesjob runs the vendored script with the flag instead of the action. Same base-ref validation, samefetch-depth: 0checkout.Why now
#14 and #15 fail only this rule. #15's commits also exceed the 60-character subject limit and will be reworded separately; that rule is kept on purpose.
Test plan
--message-fileover the commits of DuckLake: test the writes a pipeline makes into DuckDB-created tables #14 (pass) and DuckLake: detect commit conflicts against concurrent writers, retry only when safe #15 (fails on subject length only, as expected).check-commit-messagesjob exercises the new path.https://claude.ai/code/session_01WCY5Jf2BQPCVKJTZU1TpEe