docs(compliance): re-audit posthog-node Traces after 5.52.0 - #63
Closed
turnipdabeets wants to merge 1 commit into
Closed
turnipdabeets wants to merge 1 commit into
turnipdabeets wants to merge 1 commit into
Conversation
posthog-node 5.52.0 shipped native tracing, so the Traces row moves from Fail to Partial: 22 of 24 requirements met, with two retry-pacing gaps. Claude-Session: https://claude.ai/code/session_01QPLdjqTgK93WtVxnhx6aVr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
compliance/posthog-node.mdstill scored Traces ❌, based on an audit at posthog-jsfbdb6c7bfrom before tracing existed.posthog-node5.52.0 (PostHog/posthog-js#4579) shippedstartSpan/withSpan/getActiveSpanand OTLP export to/i/v1/traces. This re-audits that one row.910b0925(5.52.1) against sdk-specs4f2f48f4. 22 of 24 requirements are met.Retry-After), the events pipeline's automatic flush still sends spans.throttledonly reads theRetry-Afterwindow. That breaks "Between retries the SDK SHALL pause automatic sends".Retry-Afterwindow,flush()'s outer loop sends the next batch at the same instant. The SDK's own test pins this atindex.spec.ts:3100-3126, which contradicts the scenario "dropping a batch does not end the Retry-After window".posthog-node.md: the intro sentence that claimed no Traces support inpackages/node, and the header summary (now 10 ✅ · 17 🟡 · 7 ❌ · 28 ➖).README.md: updated the posthog-node summary row (🟡 16→17, ❌ 8→7; open gaps stay at 24), and moved the Traces gap from the ❌ table to the 🟡 table.Not changed:
README.md, which records the 2026-08-17 run's counts.@posthog/corehas the pipeline now, but browser and RN don't use it, so both stay ❌. Only the wording is stale, and it belongs in those SDKs' next re-audit.Worth a spec decision (not scored):
parentit's inert. The spec's "child of a pass-through is inert" rule doesn't settle which is right for the active case.traceparentand parents children, although the spec says it "becomes a no-op".How was this checked?
A per-requirement audit of
packages/core/src/traces/andpackages/node/src/againstopenspec/specs/traces/spec.md, citing file:line for every requirement. The two gaps were re-checked by hand against the code (index.ts:350-352,client.ts:297-317) and the spec text (lines 866-869, and the scenario at 994).Related docs PRs for the same release: PostHog/posthog#99441, PostHog/posthog.com#20109, PostHog/context-mill#391.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QPLdjqTgK93WtVxnhx6aVr