fix(desktop): keep the create button in the nav rail by rubychilds · Pull Request #97076 · PostHog/posthog

rubychilds · 2026-09-09T00:34:31Z

Problem

Collapsing the desktop sidebar (⌘B) hides the orange create button, the last mouse route to a new task.
Destinations that draw no sidebar, such as Home and Inbox, lose it the same way.

Changes

See Loom

The orange create button now lives in the nav rail, above Search, on every destination. It still files a task into the space you are in.
The floating copies over the space pane and the spaces list are gone, so there is one create button.
The Spaces heading gains a "+" for a new space, shown on hover like a row's own controls.
Off the spaces layout nothing changes: that sidebar has no rail and keeps its floating button.

How did you test this code?

NavRail tests check the button sits above Search on Home, Spaces and Inbox, and carries the current space.
ChannelsList tests check the heading "+" opens the create dialog on the spaces layout only.
Checked in the dev app with the sidebar open, collapsed, and on the spaces list.

🤖 Agent context

Claude Code (Fable 5.1) wrote the change with the author directing each step. Skills: writing-pr-descriptions.

Created with PostHog from a Slack thread

The sidebar holds every create affordance: the floating "+" and the "New task" row. Collapsing the sidebar, or landing on a destination that draws no sidebar, leaves the keyboard shortcut as the only way to start a task. Show a "New task" button in the title bar beside the sidebar toggle whenever the sidebar body is off screen. It files into the scoped channel, the same as the shortcut and the sidebar "+". Generated-By: PostHog Desktop Task-Id: ae645e0e-1651-4060-b869-5e751f874793

trunk-io · 2026-09-09T00:34:35Z

Merging to master in this repository is managed by Trunk.

To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

github-actions · 2026-09-09T00:35:51Z

React Doctor found no issues in the changed files. 🎉

_{Reviewed by React Doctor for commit 57a331e.}

github-actions · 2026-09-09T00:36:22Z

🤖 CI report

✅ Trunk lane — non-backend lane (fe:product:desktop)

This PR is assigned to the non-backend lane (fe:product:desktop). It does not run backend Python tests and may merge in parallel with PRs in other lanes.

🚨 Comment density — 20% of added code lines are comments (35 of 179)

This section warns when comments are more than 3% of the code lines a PR adds, and alerts above 6%. Before agent-assisted PRs, the typical share was about 2%. Only full-line comments count. Docstrings, generated files, snapshots, migrations, and workflow files are left out.

Comments that restate the code, record how the change came about, or narrate the next line add noise for the next reader. Keep the comments that explain a reason the code cannot show, and remove the rest. See .agents/skills/writing-code-comments/SKILL.md for the house rules.

Files with the most added comment lines:

File	Comment lines	Added lines
`products/desktop/packages/ui/src/features/canvas/components/ChannelsList.tsx`	21	80
`products/desktop/packages/ui/src/features/canvas/components/ChannelsFab.tsx`	5	24
`products/desktop/packages/ui/src/features/canvas/components/NavRail.tsx`	5	12
`products/desktop/packages/ui/src/features/canvas/components/ChannelsList.test.tsx`	2	15
`products/desktop/packages/ui/src/features/canvas/components/NavRail.test.tsx`	2	48

This check does not block merging. It updates on every push and clears when the share drops.

hosthog · 2026-09-09T00:40:39Z

HostHog preview — `posthog-desktop-web`

Latest build (57a331e): https://fae06acbd96647dab1bf2c3e877cc290.hosthog.dev

Earlier builds of this PR, still serving:

54f8176: https://e106cebae2b840aa8f9f91e9c71ec35f.hosthog.dev

Employee-gated; every push gets a fresh URL whose content never changes. All previews stop serving when the PR closes.

The orange create button lived only in the sidebar, so collapsing the sidebar took away the last mouse route to a new task. It now sits in the nav rail above Search on every destination, the floating copies in the space pane and the spaces list are gone, and the Spaces heading gets a "+" for a new space. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

coderabbitai · 2026-09-12T01:21:31Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

_{Comment @coderabbitai help to get the list of available commands.}

…apsed

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57a331e665

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-12T01:30:05Z

+          <ChannelsFab
+            channelId={currentChannelId ?? undefined}
+            placement="rail"


Keep New space available while filtering Spaces

When the Spaces search query is nonempty and a channel is scoped, this prop makes the rail FAB direct-only because ChannelsFab treats a channelId as "New task", while NewSpaceButton is only rendered in the unfiltered normalizedQuery ? ... : ... branch of ChannelsList.tsx. The previous list FAB had no channelId and retained its New space menu, so users now have to clear their search before they can create a space. Keep a New space action in the filtered state or expose it from the rail menu.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-12T01:30:05Z

+  // Off the layout, bottom padding clears the floating create button
+  // (ChannelsFab) so the last channel stays reachable at full scroll. The
+  // layout keeps that button in the rail, so the list needs no room for it.
+  const scrollClass = `scroll-mask-8 min-h-0 flex-1 overflow-y-auto px-2 pt-2 ${channelsLayout ? "pb-2" : "pb-16"}`;


Remove the forced bottom spacer from Spaces

On the Spaces layout, scrollClass now supplies pb-2, but the same list still has the existing !pb-16 class. The important Tailwind utility wins, leaving the former floating-button clearance (4rem) as dead space at the bottom of the list even though the FAB was moved to the rail. Make the important padding conditional or remove it for the Spaces layout.

Useful? React with 👍 / 👎.

rubychilds self-assigned this Sep 9, 2026

github-actions Bot added the feature/desktop Feature Tag: Desktop label Sep 9, 2026

rubychilds changed the title ~~fix(desktop): keep a new task button when the sidebar collapses~~ fix(desktop): keep the create button in the nav rail Sep 12, 2026

Merge branch 'master' into posthog/desktop-new-task-when-sidebar-coll…

57a331e

…apsed

rubychilds marked this pull request as ready for review September 12, 2026 01:24

rubychilds requested a review from a team September 12, 2026 01:24

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Navigation Menu

Uh oh!

fix(desktop): keep the create button in the nav rail - #97076

fix(desktop): keep the create button in the nav rail#97076
rubychilds wants to merge 3 commits into
masterfrom
posthog/desktop-new-task-when-sidebar-collapsed

rubychilds commented Sep 9, 2026 •

edited

Loading

Uh oh!

trunk-io Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 9, 2026 •

edited

Loading

Uh oh!

hosthog Bot commented Sep 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 12, 2026

Draft PR not reviewed

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot Sep 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

rubychilds commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this code?

🤖 Agent context

Uh oh!

trunk-io Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CI report

Uh oh!

hosthog Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

HostHog preview — posthog-desktop-web

Uh oh!

coderabbitai Bot commented Sep 12, 2026

Draft PR not reviewed

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

rubychilds commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

hosthog Bot commented Sep 9, 2026 •

edited

Loading

HostHog preview — `posthog-desktop-web`