-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(tracing): use the logs timestamp format #92400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
efb7b9b
fix(tracing): use the logs timestamp format
jonmcwest 9726309
fix(tracing): show seconds in the span row timezone popover
jonmcwest 32f9e4f
Merge branch 'master' into posthog/tracing-logs-timestamp-format
jonmcwest cf072cf
Merge branch 'master' into posthog/tracing-logs-timestamp-format
jonmcwest 956579c
chore(visual): update storybook baselines
posthog[bot] faab042
Merge branch 'master' into posthog/tracing-logs-timestamp-format
jonmcwest 2179b40
Merge branch 'master' into posthog/tracing-logs-timestamp-format
jonmcwest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| // Tracing shows timestamps the way Logs does: an ISO-ordered date and a 24-hour clock. A | ||
| // month-first date is ambiguous outside the US. | ||
| export const TRACING_DATE_FORMAT = 'YYYY-MM-DD' | ||
| export const TRACING_TIME_FORMAT = 'HH:mm:ss.SSS' | ||
|
|
||
| // Charts and range pills drop the milliseconds. A bucket edge is never sub-second. | ||
| export const TRACING_DATE_TIME_FORMAT = 'YYYY-MM-DD HH:mm:ss' | ||
|
|
||
| // Every chart, axis, and timestamp in the product reads in UTC, so a span lines up with the | ||
| // sparkline above it. TZLabel converts to the reader's own timezone on hover. | ||
| export const TRACING_DISPLAY_TIMEZONE = 'UTC' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.