Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/ci-agent-skills.yml
Original file line number Diff line number Diff line change
Expand Up @@ -515,13 +515,6 @@ jobs:
DEBUG: 1
run: ./bin/hogli build:skills

- name: Mint release GitHub token
id: release-token
uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
with:
client-id: ${{ vars.GH_APP_POSTHOG_PATHS_FILTER_APP_ID }}
private-key: ${{ secrets.GH_APP_POSTHOG_PATHS_FILTER_PRIVATE_KEY }}

- name: Determine next version
id: version
run: |
Expand All @@ -532,8 +525,11 @@ jobs:
echo "tag=agent-skills-v0.$((MINOR + 1)).0" >> "$GITHUB_OUTPUT"

- name: Create versioned release
# The job's own contents:write GITHUB_TOKEN, like build-phrocs.yml and
# build-livestream-tui.yml. No workflow triggers off these releases, so the
# app token bought nothing and only added a permission that can drift away.
Comment on lines +528 to +530

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The new comment records why the previous app-token implementation was removed, duplicating context already captured in the commit and PR description. Keeping this history beside the release step adds maintenance cost when that context becomes stale.

Suggested change
# The job's own contents:write GITHUB_TOKEN, like build-phrocs.yml and
# build-livestream-tui.yml. No workflow triggers off these releases, so the
# app token bought nothing and only added a permission that can drift away.

Context Used: AGENTS.MD (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ci-agent-skills.yml
Line: 528-530

Comment:
The new comment records why the previous app-token implementation was removed, duplicating context already captured in the commit and PR description. Keeping this history beside the release step adds maintenance cost when that context becomes stale.

```suggestion

```

**Context Used:** AGENTS.MD ([source](https://github.com/posthog/posthog/blob/master/AGENTS.MD))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

env:
GH_TOKEN: ${{ steps.release-token.outputs.token }}
GH_TOKEN: ${{ github.token }}
RELEASE_TAG: ${{ steps.version.outputs.tag }}
run: |
gh release create "$RELEASE_TAG" \
Expand All @@ -545,7 +541,7 @@ jobs:

- name: Update latest release
env:
GH_TOKEN: ${{ steps.release-token.outputs.token }}
GH_TOKEN: ${{ github.token }}
RELEASE_TAG: ${{ steps.version.outputs.tag }}
run: |
if gh release view agent-skills-latest &>/dev/null; then
Expand Down
Loading