-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(desktop): version, dismiss, and timestamp uploaded run files #78644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
trunk-io
merged 6 commits into
master
from
posthog-code/task-file-versions-and-dismissal
Aug 7, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c392aac
feat(desktop): version, dismiss, and timestamp uploaded run files
adboio 6534eeb
chore(desktop): assert the files header counts files, not uploads
adboio d1ff408
fix(desktop): keep showing files uploaded after a dismissal
adboio 352f214
fix(desktop): show a delivered file without waiting for a refresh
adboio f3d40f5
fix(desktop): stop the version menu clipping a file's age
adboio 2229b03
fix(desktop): let the picker reach a version with no id
adboio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TaskRunArtifactDTOmanually addsmetadataanddismissed_atto the generated backend response type, allowing the handwritten contract to drift from the serializer-generated schema and requiring duplicate maintenance. Please update and consume the generated response type instead.Context Used: docs/published/handbook/engineering/type-system.md (source)
Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took the intent in 2229b03, though the mechanism does not apply here.
packages/api-client/src/generated.tsis not generated despite its name. The desktop package keeps a hand-maintained mirror of the schemas it uses, which.agents/skills/posthog-desktop/SKILL.mdlists explicitly as the desktop counterpart tohogli build:openapi. It is also deliberately partial:TaskRunArtifactResponsethere omitsurlandmetadata, which the serializer does define. So there is no regeneration step to run, and consuming a generated type is not available for this package.The drift you point at was real all the same.
dismissed_atnow sits onTaskRunArtifactResponsein that mirror, matching the merged serializer (required=False, noallow_null, so optional and never null), andTaskRunArtifactDTOno longer redeclares it. The remainingmetadata?: unknownpredates this PR and stays, since its shape is polymorphic across artifact types.