Skip to content

fix(dev): load product imports in DuckLake check - #77173

Merged
trunk-io[bot] merged 2 commits into
masterfrom
posthog-code/fix-ducklake-script-imports
Aug 4, 2026
Merged

fix(dev): load product imports in DuckLake check#77173
trunk-io[bot] merged 2 commits into
masterfrom
posthog-code/fix-ducklake-script-imports

Conversation

@puemos

@puemos puemos commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Problem

PR #76032 added valid canonical products.* imports to managed warehouse code. bin/check_ducklake_up loads that code directly, but did not make the repository root importable first, so hogli start could fail in temporal-worker with ModuleNotFoundError: No module named 'products'.

Before After
Script loading Directly executes product code without the repository package root Adds the repository root to sys.path before loading product code
hogli start Can fail when PYTHONPATH does not already include the repository Resolves canonical products.* imports consistently

Changes

  • Add the repository root to the standalone DuckLake check import path.

How did you test this code?

  • Ran the import-only reproduction from outside the repository with PYTHONPATH removed.
  • Ruff and preflight checks pass.

Created with PostHog Code

@trunk-io

trunk-io Bot commented Aug 4, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@puemos puemos added the skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs label Aug 4, 2026 — with PostHog
@puemos
puemos marked this pull request as ready for review August 4, 2026 08:32
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🤖 CI report

Bundle size — no change

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 65.58 MiB · no change

No file changed by more than 1000 B.

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1.25 MiB · 22 files no change ███░░░░░░░ 27.7% of 4.51 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
8.14 MiB · 3,036 files no change ████████░░ 83.8% of 9.71 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/RootErrorBoundary.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
789 B src/scenes/ChunkLoadErrorBoundary.tsx
762 B src/index.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
285.5 KiB ../node_modules/.pnpm/posthog-js@1.410.1/node_modules/posthog-js/dist/rrweb.js
267.7 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
235.5 KiB src/taxonomy/core-filter-definitions-by-group.json
231.5 KiB ../node_modules/.pnpm/posthog-js@1.410.1/node_modules/posthog-js/dist/module.js
154.3 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
104.4 KiB src/lib/api.ts
94.7 KiB ../packages/quill/packages/quill/dist/index.js
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
90.6 KiB ../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

Toolbar bundle — eager 2.19 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric Size Δ vs base Budget
Eager (shipped)
entry + static imports
2.19 MiB · 17 files no change ████░░░░░░ 38.3% of 5.72 MiB
Deferred (lazy) 2.08 MiB · 33 files no change n/a — loads on demand
Loader dist/toolbar.js 1.1 KiB no change █░░░░░░░░░ 5.8% of 19.5 KiB
Largest eagerly-shipped chunks
Size File
718.1 KiB dist/toolbar/toolbar-app-4GT7N5VI.css
551.6 KiB dist/toolbar/chunk-chunk-2KIRIKZY.js
484.6 KiB dist/toolbar/chunk-chunk-PIOT3RXS.js
133.6 KiB dist/toolbar/chunk-chunk-NAYZ2JJF.js
131.8 KiB dist/toolbar/chunk-chunk-T5KY5WYR.js
71.0 KiB dist/toolbar/toolbar-app-66NMDAV4.js
69.0 KiB dist/toolbar/chunk-chunk-27JL52RE.js
35.6 KiB dist/toolbar/chunk-chunk-4NYOFLKW.js
20.9 KiB dist/toolbar/chunk-chunk-OYRH6LH3.js
12.2 KiB dist/toolbar/chunk-chunk-PIK3PADE.js

Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile

Dist folder size — no change

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1390.04 MiB · no change

⚠️ Playwright — 1 flaky

🎭 Playwright report · View test results →

⚠️ 1 flaky test:

  • Logout and login (chromium)

These issues are not necessarily caused by your changes.
Annoyed by this section? Help fix flakies and failures and it will go green!

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team August 4, 2026 08:33
@trunk-io

trunk-io Bot commented Aug 4, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@puemos
puemos changed the base branch from master to posthog-code/merge-artifact-comments August 4, 2026 09:27
@puemos
puemos force-pushed the posthog-code/fix-ducklake-script-imports branch 2 times, most recently from fe61860 to 34282e8 Compare August 4, 2026 09:40
@puemos puemos changed the title fix(dev): load product imports in DuckLake check feat(canvas): add selection comments and comments view Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit ef511b2.

@puemos
puemos force-pushed the posthog-code/merge-artifact-comments branch from f433ca1 to a35dec3 Compare August 4, 2026 09:59
Generated-By: PostHog Code
Task-Id: 56b16387-fd8b-4cd9-a1ed-21feda91f1b8
@puemos
puemos force-pushed the posthog-code/fix-ducklake-script-imports branch from ef511b2 to 932ce45 Compare August 4, 2026 09:59
@puemos puemos changed the title feat(canvas): add selection comments and comments view fix(dev): load product imports in DuckLake check Aug 4, 2026
@puemos
puemos changed the base branch from posthog-code/merge-artifact-comments to master August 4, 2026 10:00
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🦔 Hogbox preview · ✅ ready

▶ Open the preview

🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend on the PostHog :master base (frontend unchanged by this PR)
🔗 Link stable across rebuilds — a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit 932ce45 · box box-74f6e55a1899 · ready in 718s (push → usable) · build log · rebuilds on every push, torn down on close

@trunk-io
trunk-io Bot merged commit 16fd2eb into master Aug 4, 2026
203 of 205 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/fix-ducklake-script-imports branch August 4, 2026 18:23
@deployment-status-posthog

deployment-status-posthog Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-08-04 19:16 UTC Run
prod-us ✅ Deployed 2026-08-04 19:46 UTC Run
prod-eu ✅ Deployed 2026-08-04 19:40 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants