Skip to content

fix(tasks): allow max reasoning for gpt-5.6 #70351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tatoalo merged 1 commit into from
Jul 13, 2026
Merged

fix(tasks): allow max reasoning for gpt-5.6 #70351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions products/tasks/backend/temporal/process_task/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,12 @@ class ReasoningEffort(StrEnum):
*CODEX_REASONING_EFFORTS,
ReasoningEffort.XHIGH,
)
CODEX_XHIGH_REASONING_MODELS: frozenset[str] = frozenset({"gpt-5.5", "gpt-5.6-sol", "gpt-5.6-terra", "gpt-5.6-luna"})
CODEX_MAX_REASONING_EFFORTS: tuple[ReasoningEffort, ...] = (
*CODEX_XHIGH_REASONING_EFFORTS,
ReasoningEffort.MAX,
)
CODEX_XHIGH_REASONING_MODELS: frozenset[str] = frozenset({"gpt-5.5"})
CODEX_MAX_REASONING_MODELS: frozenset[str] = frozenset({"gpt-5.6-sol", "gpt-5.6-terra", "gpt-5.6-luna"})

# Canonical list of Codex models. The runtime technically accepts any
# `gpt-*` identifier passed through, but only models on this list are
Expand Down Expand Up @@ -198,7 +203,10 @@ def get_supported_reasoning_efforts(
if adapter_value == RuntimeAdapter.CLAUDE.value:
return CLAUDE_REASONING_EFFORTS_BY_MODEL.get(model, ())
if adapter_value == RuntimeAdapter.CODEX.value:
if model.lower() in CODEX_XHIGH_REASONING_MODELS:
normalized_model = model.lower()
if normalized_model in CODEX_MAX_REASONING_MODELS:
return CODEX_MAX_REASONING_EFFORTS
if normalized_model in CODEX_XHIGH_REASONING_MODELS:
return CODEX_XHIGH_REASONING_EFFORTS
return CODEX_REASONING_EFFORTS

Expand Down
3 changes: 2 additions & 1 deletion products/tasks/backend/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2061,7 +2061,9 @@ def test_run_endpoint_accepts_token_even_without_linked_identity(self, mock_work
("gpt_5_3_high", "gpt-5.3-codex", "high"),
("gpt_5_5_xhigh", "gpt-5.5", "xhigh"),
("gpt_5_6_sol_xhigh", "gpt-5.6-sol", "xhigh"),
("gpt_5_6_sol_max", "gpt-5.6-sol", "max"),
("gpt_5_6_luna_xhigh", "gpt-5.6-luna", "xhigh"),
("gpt_5_6_luna_max", "gpt-5.6-luna", "max"),
]
)
@patch("products.tasks.backend.temporal.client.execute_task_processing_workflow")
Expand Down Expand Up @@ -2289,7 +2291,6 @@ def test_run_endpoint_rejects_incomplete_runtime_selection(self, _case_name, pay
("gpt_5_4_xhigh", "gpt-5.4", "xhigh", "low, medium, high"),
("gpt_5_4_max", "gpt-5.4", "max", "low, medium, high"),
("gpt_5_5_max", "gpt-5.5", "max", "low, medium, high, xhigh"),
("gpt_5_6_sol_max", "gpt-5.6-sol", "max", "low, medium, high, xhigh"),
]
)
@patch("products.tasks.backend.temporal.client.execute_task_processing_workflow")
Expand Down
Loading