Skip to content

feat(traces): span export queue with retries - #954

Open
turnipdabeets wants to merge 2 commits into
traces/05-pipelinefrom
traces/06-export
Open

turnipdabeets wants to merge 2 commits into
traces/05-pipelinefrom
traces/06-export

Conversation

@turnipdabeets

@turnipdabeets turnipdabeets commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

💡 Motivation and Context

Adds SpanExporter, the in-memory queue ended spans wait in until they are batched and sent, separate from the events queue.

  • A timer flushes every flush_interval; a full batch flushes at once; only one flush runs at a time.
  • A full queue drops the incoming span, never a queued parent.
  • Failures back off exponentially with jitter, floored by Retry-After (clamped to 30 s, extended by a later deadline but never shortened). Automatic sends pause while backing off.
  • A batch refused across 8 backoff windows is dropped. A 413 halves the batch and ramps back. Other 4xx drop the batch.
  • flush(timeout) always sends the first batch, so a serverless handler with no budget left still ships spans.

Not reachable from the client yet.

Stack (PR 6 of 9, based on traces/05-pipeline):

  1. feat(traces): W3C trace context ids and traceparent parsing #949 traces/01-ids-traceparent
  2. feat(traces): OTLP span encoding and client-side validity #950 traces/02-otlp-encoding
  3. feat(traces): span handles #951 traces/03-span-handles
  4. feat(traces): span batch transport #952 traces/04-transport
  5. feat(traces): span pipeline #953 traces/05-pipeline
  6. feat(traces): span export queue with retries #954 traces/06-export ← this PR
  7. feat(traces): per-span limits and exception stacktraces #955 traces/07-span-limits
  8. feat(traces): before_span_send hook #956 traces/08-before-span-send
  9. feat(traces): wire tracing into the client #957 traces/09-client-wiring

💚 How did you test it?

Unit tests in posthog/test/tracing/test_export.py cover timer and size flushes, backoff and Retry-After, 413 halving, drop rules and the bounded flush(timeout).

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran sampo add to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Implemented with Claude Code (Claude Opus 5) against the traces spec, one commit per slice so each PR reviews on its own. Rebased onto main and opened as a stacked draft in a later Claude Code session (Claude Fable 5.1).

🤖 Generated with Claude Code

https://claude.ai/code/session_012o7CtHLfcypjmXL7g9ZGRC

@turnipdabeets turnipdabeets self-assigned this Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

posthog-python Compliance Report

Date: 2026-09-15 22:09:28 UTC
Duration: 256445ms

✅ All Tests Passed!

111/111 tests passed


Capture_V1 Tests

94/94 tests passed

View Details
Test Status Duration
Endpoint And Method.Targets V1 Endpoint 517ms
Endpoint And Method.Does Not Use Legacy Endpoints 511ms
Required Headers.Has Authorization Bearer Header 510ms
Required Headers.Has Content Type Json 510ms
Required Headers.Has Posthog Sdk Info Format 511ms
Required Headers.Has Posthog Attempt Header 513ms
Required Headers.Has Posthog Request Id 511ms
Required Headers.Has Posthog Request Timestamp 513ms
Required Headers.Has User Agent 511ms
Body Format.Body Has Created At And Batch 510ms
Body Format.No Api Key In Body 511ms
Body Format.No Sent At In Body 511ms
Event Format.Event Has Required Root Fields 510ms
Event Format.Event Uuid Is Valid 511ms
Event Format.Event Timestamp Is Rfc3339 510ms
Event Format.Distinct Id Is String 510ms
Event Format.Distinct Id At Root Not Properties 511ms
Event Format.Custom Properties Preserved 510ms
Event Format.Set Properties Preserved 510ms
Event Format.Set Once Properties Preserved 511ms
Event Format.Groups Properties Preserved 510ms
Event Format.Sdk Generates Uuid If Not Provided 510ms
Event Format.Event Has Required Root Fields Batch 514ms
Event Format.Event Uuid Is Valid Batch 514ms
Event Format.Event Timestamp Is Rfc3339 Batch 514ms
Event Format.Distinct Id Is String Batch 514ms
Event Format.Distinct Id At Root Not Properties Batch 514ms
Event Format.Custom Properties Preserved Batch 514ms
Event Format.Set Properties Preserved Batch 514ms
Event Format.Set Once Properties Preserved Batch 513ms
Event Format.Groups Properties Preserved Batch 514ms
Event Format.Sdk Generates Uuid If Not Provided Batch 514ms
Batch Behavior.Multiple Events In Single Batch 518ms
Batch Behavior.Batch Envelope Smoke 515ms
Batch Behavior.Flush With No Events Sends Nothing 507ms
Batch Behavior.Flush At Triggers Batch 1011ms
Batch Behavior.Created At Reflects Batch Creation Time 511ms
Deduplication.Generates Unique Uuids 518ms
Deduplication.Different Events Same Content Different Uuids 513ms
Deduplication.Preserves Uuid On Retry 6515ms
Deduplication.Preserves Timestamp On Retry 6522ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 6520ms
Deduplication.No Duplicate Events In Batch 519ms
Header Behavior On Retry.Attempt Header Starts At One 510ms
Header Behavior On Retry.Attempt Header Increments On Retry 13523ms
Header Behavior On Retry.Request Id Preserved On Retry 6517ms
Header Behavior On Retry.Different Requests Have Different Request Ids 3021ms
Header Behavior On Retry.Request Timestamp Changes On Retry 6521ms
Response Format Validation.Success Response Has Uuid Keyed Results 512ms
Response Format Validation.Success Response Has Ok For Each Event 515ms
Response Format Validation.Success No Retry After When All Ok 513ms
Response Format Validation.Success Retry After Present When Retry Events 1516ms
Response Format Validation.Success No Retry After When Drop Only 513ms
Response Format Validation.Response Echoes Request Id 516ms
Retry Behavior.Retries On 408 6519ms
Retry Behavior.Retries On 500 6519ms
Retry Behavior.Retries On 503 8523ms
Retry Behavior.Retries On 504 6517ms
Retry Behavior.Retryable Errors Have Retry After 3517ms
Retry Behavior.Respects Retry After On Retryable Error 11521ms
Retry Behavior.Does Not Retry On 400 2514ms
Retry Behavior.Does Not Retry On 401 2514ms
Retry Behavior.Does Not Retry On 402 2514ms
Retry Behavior.Does Not Retry On 413 2513ms
Retry Behavior.Does Not Retry On 415 2513ms
Retry Behavior.Non Retryable Errors Have No Retry After 2513ms
Retry Behavior.Implements Backoff 22525ms
Retry Behavior.Max Retries Respected 22538ms
Partial Batch Handling.Handles 200 Full Success 2514ms
Partial Batch Handling.Handles 200 With All Ok 3519ms
Partial Batch Handling.Does Not Retry Dropped Events 3517ms
Partial Batch Handling.Does Not Retry Limited Events 3518ms
Partial Batch Handling.Prunes Ok Events On Partial Retry 6524ms
Partial Batch Handling.Prunes Dropped Events On Partial Retry 6520ms
Partial Batch Handling.Retries Only Retry Events From Partial 6524ms
Partial Batch Handling.Partial Retry Preserves Uuids 6522ms
Partial Batch Handling.Partial Retry Attempt Header Increments 6523ms
Partial Batch Handling.Partial Retry Request Id Preserved 6523ms
Partial Batch Handling.Respects Retry After On Partial 8525ms
Partial Batch Handling.Unknown Result Treated As Terminal 3516ms
Partial Batch Handling.Mixed Ok Drop Limited No Retry 3517ms
Compression.Sends Gzip Content Encoding 511ms
Compression.No Content Encoding When Disabled 511ms
Compression.Compressed Body Is Decompressible 510ms
Error Handling.Does Not Retry On Unknown 4Xx 2512ms
Event Options.Cookieless Mode Override 512ms
Event Options.Disable Skew Correction Override 510ms
Event Options.Process Person Profile Override 511ms
Event Options.Product Tour Id Override 511ms
Event Options.Unset Options Omitted 510ms
Event Options.Options Override In Batch 513ms
Geoip And Historical Migration.Geoip Disable Injected Into Properties 512ms
Geoip And Historical Migration.Historical Migration Set In Body 512ms
Geoip And Historical Migration.Historical Migration Absent By Default 511ms

Feature_Flags Tests

17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 12ms
Request Payload.Flags Request Uses V2 Query Param 12ms
Request Payload.Flags Request Hits Flags Path Not Decide 10ms
Request Payload.Flags Request Omits Authorization Header 12ms
Request Payload.Token In Flags Body Matches Init 10ms
Request Payload.Groups Round Trip 12ms
Request Payload.Groups Default To Empty Object 9ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 10ms
Request Payload.Disable Geoip Omitted Defaults To False 10ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 14ms
Request Lifecycle.No Flags Request On Init Alone 4ms
Request Lifecycle.No Flags Request On Normal Capture 510ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 15ms
Request Lifecycle.Mock Response Value Is Returned To Caller 10ms
Retry Behavior.Retries Flags On 502 313ms
Retry Behavior.Retries Flags On 504 313ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 512ms

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Important Files Changed

Filename Overview
posthog/tracing/_export.py Adds the span queue, batching, retries, and timers. The timer replacement can lose a zero-delay flush.
posthog/test/tracing/test_export.py Adds broad tests for batching, retries, drops, deadlines, and timers. The fake timer does not cover a callback that runs during start().
posthog/test/tracing/helpers.py Adds tracing test helpers and timer fakes.
Prompt To Fix All With AI
### Issue 1
posthog/tracing/_export.py:449-452
`timer.start()` can run the callback before `_flush_timer` points to the new timer. A zero-delay flush can then look stale and return. The old timer is canceled, and the dead timer is stored. Publish the replacement before starting it, and restore the old timer if `start()` fails.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (2): Last reviewed commit: "fix(traces): keep the scheduled flush wh..." | Re-trigger Greptile

Comment thread posthog/tracing/_export.py
Comment thread posthog/tracing/_export.py Outdated
Comment thread posthog/tracing/_export.py
Comment thread posthog/tracing/_export.py

@dustinbyrne dustinbyrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the export-queue slice, with one non-blocking note: _export.py:182 calls warn_if_due(force=True) after every flush, including automatic flushes. Repeated rejected batches can therefore emit a warning per flush rather than at most once per configured interval. Consider reserving forced reporting for shutdown/exit and updating the fixed-clock test that currently expects two warnings in one interval.

The transport and pipeline feedback belongs to their respective stack PRs; this approval does not cover the complete public tracing release.

AI-assisted review using source, tests and existing CI; no new tests were run.

turnipdabeets and others added 2 commits September 15, 2026 18:01
Adds SpanExporter, the in-memory queue ended spans wait in until they are
batched and sent, separate from the events queue. A timer flushes every
flush_interval and a full batch flushes at once; only one flush runs at a time.
A full queue drops the incoming span, never a queued parent. Failures back off
exponentially with jitter, floored by Retry-After (clamped to 30 s, extended by
a later deadline but never shortened), and automatic sends pause while backing
off. A batch refused across 8 backoff windows is dropped, a 413 halves the
batch and ramps back, and other 4xx drop it. flush(timeout) always sends the
first batch, so a serverless handler with no budget left still ships spans.
Not reachable from the client.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TkZAsCciW4PV8ZdcCHmAbA
…to start, and count an unencodable span once

The replacement timer now starts before the old one is cancelled, so a
thread that cannot be created leaves the earlier flush in place. Records
that fail to encode leave the queue before the send is settled, so a
failed send no longer counts them a second time.
@turnipdabeets

Copy link
Copy Markdown
Contributor Author

Thanks. We warn after every flush on purpose, to match Node. It calls _warnAboutDrops() at the end of every flush and has a test called "warns once per flush with the total". The once-per-interval rule is for drops that happen outside a flush, like a full queue during an outage.

@dustinbyrne dustinbyrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, confirmed against Node: the flush path calls _warnAboutDrops(), with an explicit once-per-flush test. I withdraw my warning-cadence suggestion. The spec wording should be reconciled separately, not by changing Python alone. Approval stands.

AI-assisted follow-up source review, including Node parity and the rebased transport change; no new tests run locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants