chore: attribute rrweb changes to posthog-js in changeset hygiene - #4810
Draft
marandaneto wants to merge 1 commit into
Draft
chore: attribute rrweb changes to posthog-js in changeset hygiene#4810marandaneto wants to merge 1 commit into
marandaneto wants to merge 1 commit into
Conversation
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The changeset hygiene bot asks for rrweb changesets, but packages under
packages/rrweb/ship withposthog-jsand do not need their own changesets.Example: #4808 (comment)
Changes
Add
.changeset/hygiene.jsonto map all source paths underpackages/rrweb/toposthog-js. This removes the separate rrweb requirement while still checking for a browser SDK changeset. Other packages keep their existing checks.Pin the shared hygiene script to the implementation in PostHog/.github#74. Merge that PR first. The pin points to its exact implementation commit.
Validation:
git diff --checkpass.Release info Sub-libraries affected
Libraries affected
None. This only changes PR automation and does not need an SDK changeset.
Checklist
If releasing new changes
Not applicable. No published package changes.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Pi using file tools, Git, GitHub CLI, Node tests, and autoreview for the shared script. rrweb paths are mapped to the browser SDK rather than ignored, so changes still require the changeset for the package that ships them. Human review is required.