fix(react-native): refresh displayed survey translations - #4802
Open
marandaneto wants to merge 1 commit into
Open
fix(react-native): refresh displayed survey translations#4802marandaneto wants to merge 1 commit into
marandaneto wants to merge 1 commit into
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix(react-native): refresh displayed sur..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Displayed React Native surveys keep their old translations when the person's language changes. Later survey events also keep the old language.
Addresses #4175.
Changes
posthog-react-native.Validation
c17cff461a710c958c69e40947d06ec3cbedbe63. Its one finding assumed reordered choices. That finding was rejected after checking that the current RN display-order helper always returns the original choice array.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset fileExisting patch changeset included in this branch.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi implemented and validated this user-directed fix using repository tools. The Pi autoreview helper reviewed the committed branch. Work was kept inside the React Native survey implementation, with no dependency or configuration changes. Local session reference:
510ebebc-a750-45a5-88ce-92821ccd3256.The person-property notification and index-based choice state preserve in-progress answers instead of remounting the survey. Human review is required before merging.