fix(flags): honor versioned local property matching - #4800
Draft
marandaneto wants to merge 2 commits into
Draft
Conversation
Contributor
Contributor
posthog-node Compliance ReportDate: 2026-09-05 12:02:11 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
|
Size Change: +4.13 kB (+0.02%) Total Size: 20.4 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
posthog-js Compliance ReportDate: 2026-09-05 12:05:20 UTC ✅ All Tests Passed!26/26 tests passed Capture Tests✅ 26/26 tests passed View Details
|
marandaneto
marked this pull request as ready for review
September 5, 2026 17:29
Contributor
|
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
marandaneto
marked this pull request as draft
September 6, 2026 07:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Node and Convex local feature flag evaluation needs to honor the definitions response's
property_matching_version. Without it, boolean-like filters keep using legacy truthiness even when the server selects explicit matching.Backend behavior: PostHog/posthog#90694. Shared contract: PostHog/sdk-specs#59.
Changes
is_notcomplements exact matching for known properties.FlagDefinitionCacheData.propertyMatchingVersion.Existing numeric ambiguity fallback and SemVer parsing policies are unchanged. There are no browser, mobile or SDK adapter changes. Optional harness coverage is tracked separately in PostHog/posthog-sdk-test-harness#53. This PR does not opt an adapter in.
Validation
On the final committed branch:
origin/mainreported no actionable findings.Prior implementation validation also passed focused new-test typechecks for all three packages. The earlier broad Node run had 944 passing tests and two unrelated failures in
extensions/exception-autocapture.spec.ts: uncaught errors and unhandled rejections could not resolve extensionlessdist/versionimported bydist/client.mjs. That run also reported an unhandled rejection with the same error. Broad test-inclusive TypeScript checks reported existing fixture/mock errors, including readonly JSON arrays in core tests, Node mock signatures, and the Convexcrons.test.tsmock type. These broad checks were not rerun or repaired for this PR.Checks used the existing cached Node 26.8.1, pnpm 11.7.0 and Vitest 1.6.1 toolchain. Node differs from the root's 24.x engine requirement. Existing API Extractor TSDoc warnings remain. The API snapshot keeps the generator's formatting rather than reformatting unrelated JSON. This is local validation, not a claim that CI has passed.
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
A human directed this work using Pi, Git, GitHub CLI and the isolated autoreview helper. The session is local and has no public session link. The implementation follows the shared matching contract, preserves legacy defaults and leaves browser/mobile behavior and adapter opt-in out of scope. Human review is required before merge.