chore: improve CI workflow linting#652
Conversation
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
.github/workflows/build.yml:13-15
`cancel-in-progress` applies to `main` branch pushes
The concurrency group falls back to `github.ref` (i.e., `refs/heads/main`) when there is no PR number. With `cancel-in-progress: true`, a second merge to `main` while any of these workflows are still running for the previous commit will cancel those in-progress runs — meaning some merged commits on `main` may never have a completed CI run. The same pattern is applied across all five workflows. Consider scoping cancellation to PR events only, e.g. by setting `cancel-in-progress: ${{ github.event_name == 'pull_request' }}`.
Reviews (1): Last reviewed commit: "chore: improve CI workflow linting" | Re-trigger Greptile |
posthog-ios Compliance ReportDate: 2026-06-11 15:35:35 UTC
|
| Test | Status | Duration |
|---|---|---|
| Format Validation.Event Has Required Fields | ✅ | 2817ms |
| Format Validation.Event Has Uuid | ✅ | 3048ms |
| Format Validation.Event Has Lib Properties | ✅ | 2759ms |
| Format Validation.Distinct Id Is String | ✅ | 2704ms |
| Format Validation.Token Is Present | ✅ | 3018ms |
| Format Validation.Custom Properties Preserved | ✅ | 3028ms |
| Format Validation.Event Has Timestamp | ✅ | 2923ms |
| Retry Behavior.Retries On 503 | ❌ | 7750ms |
| Retry Behavior.Does Not Retry On 400 | ✅ | 4796ms |
| Retry Behavior.Does Not Retry On 401 | ✅ | 4797ms |
| Retry Behavior.Respects Retry After Header | ✅ | 7790ms |
| Retry Behavior.Implements Backoff | ✅ | 17809ms |
| Retry Behavior.Retries On 500 | ✅ | 7792ms |
| Retry Behavior.Retries On 502 | ✅ | 7898ms |
| Retry Behavior.Retries On 504 | ✅ | 7850ms |
| Retry Behavior.Max Retries Respected | ❌ | 17829ms |
| Deduplication.Generates Unique Uuids | ✅ | 765ms |
| Deduplication.Preserves Uuid On Retry | ✅ | 7788ms |
| Deduplication.Preserves Uuid And Timestamp On Retry | ❌ | 12918ms |
| Deduplication.Preserves Uuid And Timestamp On Batch Retry | ✅ | 7881ms |
| Deduplication.No Duplicate Events In Batch | ✅ | 2864ms |
| Deduplication.Different Events Have Different Uuids | ✅ | 2730ms |
| Compression.Sends Gzip When Enabled | ✅ | 2758ms |
| Batch Format.Uses Proper Batch Structure | ✅ | 2710ms |
| Batch Format.Flush With No Events Sends Nothing | ✅ | 313ms |
| Batch Format.Multiple Events Batched Together | ❌ | 3190ms |
| Error Handling.Does Not Retry On 403 | ✅ | 4796ms |
| Error Handling.Does Not Retry On 413 | ❌ | 4987ms |
| Error Handling.Retries On 408 | ✅ | 7765ms |
Failures
retry_behavior.retries_on_503
Expected at least 3 requests, got 2
retry_behavior.max_retries_respected
Expected 4 requests, got 3
deduplication.preserves_uuid_and_timestamp_on_retry
Expected at least 3 requests, got 2
batch_format.multiple_events_batched_together
Expected 1 requests, got 4
error_handling.does_not_retry_on_413
Expected 1 requests, got 2
Feature_Flags Tests
View Details
| Test | Status | Duration |
|---|---|---|
| Request Payload.Request With Person Properties Device Id | ❌ | 2834ms |
| Request Payload.Flags Request Uses V2 Query Param | ✅ | 2813ms |
| Request Payload.Flags Request Hits Flags Path Not Decide | ✅ | 2881ms |
| Request Payload.Flags Request Omits Authorization Header | ✅ | 2928ms |
| Request Payload.Token In Flags Body Matches Init | ✅ | 2846ms |
| Request Payload.Groups Round Trip | ✅ | 2919ms |
| Request Payload.Groups Default To Empty Object | ❌ | 2895ms |
| Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It | ❌ | 2843ms |
| Request Payload.Disable Geoip False Propagates As Geoip Disable False | ❌ | 2889ms |
| Request Payload.Disable Geoip Omitted Defaults To False | ❌ | 2890ms |
| Request Payload.Flag Keys To Evaluate Contains Only Requested Key | ❌ | 2907ms |
| Request Lifecycle.No Flags Request On Init Alone | ✅ | 81ms |
| Request Lifecycle.No Flags Request On Normal Capture | ✅ | 2886ms |
| Request Lifecycle.Two Flag Calls Produce Two Remote Requests | ✅ | 3250ms |
| Request Lifecycle.Mock Response Value Is Returned To Caller | ✅ | 2759ms |
| Side Effect Events.Get Feature Flag Captures Feature Flag Called Event | ✅ | 3020ms |
Failures
request_payload.request_with_person_properties_device_id
Expected distinct_id='test_user_123', got '019EB752-67A2-70E1-B0AE-98D00C37C336'
request_payload.groups_default_to_empty_object
Field 'group_properties' not found in /flags request body at path 'group_properties'. Available keys: ['$device_id', 'timezone', 'distinct_id', 'person_properties', 'api_key', '$anon_distinct_id', 'groups']
request_payload.person_properties_distinct_id_auto_populated_when_caller_omits_it
Field 'distinct_id' not found in /flags request body at path 'person_properties.distinct_id'. Available keys: ['$os_name', '$os_version', 'email', '$lib_version', '$device_type', '$lib', '$app_namespace']
request_payload.disable_geoip_false_propagates_as_geoip_disable_false
Field 'geoip_disable' not found in /flags request body at path 'geoip_disable'. Available keys: ['groups', 'person_properties', '$device_id', 'timezone', 'distinct_id', '$anon_distinct_id', 'api_key']
request_payload.disable_geoip_omitted_defaults_to_false
Field 'geoip_disable' not found in /flags request body at path 'geoip_disable'. Available keys: ['groups', 'person_properties', 'distinct_id', '$device_id', '$anon_distinct_id', 'api_key', 'timezone']
request_payload.flag_keys_to_evaluate_contains_only_requested_key
Field 'flag_keys_to_evaluate' not found in /flags request body at path 'flag_keys_to_evaluate'. Available keys: ['person_properties', 'distinct_id', 'groups', 'api_key', '$anon_distinct_id', 'timezone', '$device_id']
|
Reviews (2): Last reviewed commit: "address pr review feedback" | Re-trigger Greptile |
💡 Motivation and Context
CI workflow runs should cancel outdated jobs for the same PR without canceling completed coverage for merged commits on
main, and lint workflow commands should stay centralized in the Makefile instead of being duplicated in GitHub Actions.💚 How did you test it?
make -n swiftFormatCheckmake -n swiftLintCheckmake lintgit diff --checkrg -n "cancel-in-progress" .github/workflows/build-examples.yml .github/workflows/build.yml .github/workflows/lint.yml .github/workflows/sdk-compliance.yml .github/workflows/test.yml📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file