Skip to content

fix: make TCP drop recovery test deterministic #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 3 commits into from
Jul 1, 2026
Merged

fix: make TCP drop recovery test deterministic #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
308ef37
fix: make TCP drop recovery test deterministic
marandaneto Jul 1, 2026
90a77e9
ci: allow flags board workflow secrets inheritance
marandaneto Jul 1, 2026
e8d0970
address pr review feedback
marandaneto Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/call-flags-project-board.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,17 @@ on:
pull_request:
types: [opened, ready_for_review, review_requested, synchronize, converted_to_draft, reopened]

permissions: {}

jobs:
call-flags-project:
uses: PostHog/.github/.github/workflows/flags-project-board.yml@d8b55d05dc5150f05c24542a6397ff3ecfbfb56d
uses: PostHog/.github/.github/workflows/flags-project-board.yml@69336b569d22687f8982eea6ff7d450a885cda05
with:
pr_number: ${{ github.event.pull_request.number }}
pr_node_id: ${{ github.event.pull_request.node_id }}
is_draft: ${{ github.event.pull_request.draft }}
secrets: inherit
# The central .github reusable workflow does not declare workflow_call.secrets,
# so explicit secret mapping makes GitHub reject this caller at startup.
# It gates fork/Dependabot PRs before using secrets; keep this scoped call
# as an intentional exception to the broad-inheritance Semgrep rule.
secrets: inherit # nosemgrep
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
4 changes: 2 additions & 2 deletions extras/tcp_drop_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ func TestTCPDropRecovery(t *testing.T) {

url, err := server.Start()
require.NoError(t, err, "Failed to start server")
defer server.Close()
t.Logf("TCP server started at %s", url)

callback := newTestCallback(t)
Expand Down Expand Up @@ -91,6 +90,7 @@ func TestTCPDropRecovery(t *testing.T) {
}

client.Close()
require.NoError(t, server.Close(), "Failed to close server")

success, failure := callback.GetCounts()
assert.Equal(t, 1, success, "Expected 1 success")
Expand Down Expand Up @@ -148,7 +148,6 @@ func TestTCPDropFailure(t *testing.T) {

url, err := server.Start()
require.NoError(t, err, "Failed to start server")
defer server.Close()
t.Logf("TCP server started at %s", url)

callback := newTestCallback(t)
Expand Down Expand Up @@ -187,6 +186,7 @@ func TestTCPDropFailure(t *testing.T) {
}

client.Close()
require.NoError(t, server.Close(), "Failed to close server")

success, failure := callback.GetCounts()
assert.Equal(t, 10, server.ConnCount())
Expand Down
Loading