fix(deps): regenerate sdk_compliance_adapter lock file - #310
Merged
Conversation
#309 bumped the central package versions but left this lock file at the old ones, so the adapter's Docker build fails `dotnet restore --locked-mode`. The adapter is not in PostHog.sln, so the solution-wide regeneration missed it, and the SDK compliance job is not a required check, so #309 merged red.
turnipdabeets
enabled auto-merge (squash)
August 28, 2026 18:48
Contributor
|
Reviews (1): Last reviewed commit: "fix(deps): regenerate sdk_compliance_ada..." | Re-trigger Greptile |
Contributor
posthog-dotnet Compliance ReportDate: 2026-08-28 18:49:36 UTC ✅ All Tests Passed!17/17 tests passed Feature_Flags Tests✅ 17/17 tests passed View Details
|
dustinbyrne
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#309 bumped the central package versions but left
sdk_compliance_adapter/packages.lock.jsonpinned to the old ones (Microsoft.Extensions.Configuration[9.0.1, )vs10.0.11inDirectory.Packages.props), so the adapter's Docker build failsdotnet restore --locked-modeand the SDK compliance job is red on main.The adapter is not in
PostHog.sln, so the solution-wide--force-evaluatethat fixed the other ten lock files missed it. That job also isn't a required check — it only emits a::warning::— so #309 merged with it failing.Regenerated with
dotnet restore sdk_compliance_adapter/SdkComplianceAdapter.csproj --force-evaluate. Verified locked-mode restore and build pass on top of main.