docs(surveys): correct EmojiRating unselected tint in KDoc - #751
Merged
Conversation
The KDoc said unselected emojis use ratingButtonColor. The code tints them with inputTextColor at 50% alpha, which matches the iOS SDK. Correct the doc to describe what the code does. Generated-By: PostHog Desktop Task-Id: d4c503a5-e8e6-46d4-aedc-0ad42bfef186
Contributor
|
The summary said the control renders 3 or 5 face shapes. emojisForScale maps a 2-point scale to thumbs up and thumbs down, and there is a preview for that case. The surrounding comments already describe thumbs; the class KDoc was the last place that did not. Also give the unselected clause its noun. Generated-By: PostHog Desktop Task-Id: d4c503a5-e8e6-46d4-aedc-0ad42bfef186
phillram
marked this pull request as ready for review
September 1, 2026 22:47
Contributor
|
Reviews (1): Last reviewed commit: "docs(surveys): note thumbs scale in Emoj..." | Re-trigger Greptile |
marandaneto
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The
EmojiRatingKDoc says unselected emojis useratingButtonColor. The code tints them withinputTextColorat 50% alpha:The code is right and matches the iOS SDK, so this corrects the doc to describe what it does.
ratingButtonColoris not read in this file at all, which makes the old wording actively misleading for anyone reasoning about survey appearance across platforms.Spotted by an SDK user while they were investigating a related iOS rendering bug (posthog-ios#793).
💚 How did you test it?
Not built — comment-only change, no behavior touched. I checked that both KDoc links resolve:
ResolvedSurveyAppearancedeclaresinputTextColorandratingButtonActiveColor.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset fileNo changeset — nothing user-facing changes, so there is nothing to put in release notes.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Written with Claude Opus in PostHog Desktop. This came out of investigating an iOS emoji rating bug, where the Android implementation was the reference for correct behavior. Reading it turned up the doc mismatch. Verified against the source rather than the report: read the tint branch and the
ResolvedSurveyAppearancefields before editing.Created with PostHog Desktop